5564 Commits
Author SHA1 Message Date
0269797b0a Gh 1.3.3v2 (#11011)
* Non Hobo patch the winstaller for CVE-2022-0778 (#10995)

* install.sh is not upgrading OpenSSL on MacOS (#11003)

* MacOS isn't updating OpenSSL in install.sh

* Exit if no brew on MacOS

* Code the if tree like a pro instead.

Co-authored-by: Kyle Altendorf <sda@fstab.net>

Co-authored-by: Kyle Altendorf <sda@fstab.net>

* Remove hobo patch

* apt show not needed (#10997)

* install/upgrade openssl on Arch Linux also

* Update CHANGELOG

* revert Arch change backport

Co-authored-by: Kyle Altendorf <sda@fstab.net>
1.3.3
2022-04-02 23:59:03 -07:00
cdb24ba518 Get updated openssl version (#10991)
* Get updated openssl version

* Update pyinstaller

* Fix typo

* lets try this

* Let's try this

* Try this

Co-authored-by: Earle Lowe <e.lowe@chia.net>
1.3.2
2022-04-01 15:53:40 -07:00
William AllenandGitHub 9b7b4d7d2c Merge pull request #10989 from Chia-Network/wallentx/v1.3.2
Updating changelog
2022-04-01 17:34:29 -05:00
Gene HoffmanandGene Hoffman f88abecba0 Check for vulnerable openssl (#10988)
* Check for vulnerable openssl

* Update OpenSSL on MacOS

* First attempt - openssl Ubuntu 18.04 and 20.04

* place local/bin ahead in PATH

* specify install openssl

* correct path

* run ldconfig

* stop building and check for patched openssl

* spell sudo right by removing it

* Remove openssl building - 1st attempt RHs

* Test Windows OpenSSL version HT @AmineKhaldi
2022-04-01 13:54:17 -07:00
Kyle Altendorfandwallentx 1db42fac48 restrict click to < 8.1 for black
https://github.com/pallets/click/issues/2225

Doing this instead of updating since updating black will change several
files due to some formatting change.  I would like to take that on
separately from unbreaking CI.
2022-04-01 13:52:33 -05:00
Chris Marslenderandwallentx 45512c7140 Update appdmg to 0.6.4 to work with macos 12.3 (#10886) 2022-04-01 13:46:11 -05:00
wallentx 85ce1ba8ef Updating changelog 2022-04-01 13:21:00 -05:00
William AllenandGitHub bf2976a2a9 Updating Changelog for point release (#10781)
* Updating Changelog for point release

* Adding missing changelog items
1.3.1
2022-03-16 17:08:33 -07:00
Kyle AltendorfandGitHub da6f668f0c update chia-blockchain-gui one commit for npm build fix (#10776) 2022-03-16 16:21:46 -07:00
Arvid NorbergandGitHub 7bab39161f more entropy in random listen ports (#10743) 2022-03-16 12:03:56 -07:00
Adam KellyandGitHub 7bbfa30a24 Ak.setup nodes (#10619)
* Remove unused test code

* Centralize fixture uses of setup_n_nodes

* Centralize fixure uses of setup_two_nodes

* Break up setup_nodes into setup_services, for individial services, and setup_nodes, for initializing different simulator configurations

* Sort imports
2022-03-16 11:47:54 -07:00
Adam KellyandGitHub 185a483d0d Remove unused test code (#10614) 2022-03-15 10:33:33 -07:00
Adam KellyandGitHub aa7123053b Convert helper method do_spend from a class method to a function (#10613) 2022-03-15 10:33:05 -07:00
JeffandGitHub fc453e637c Fixed test failures on Windows. (#10740) 2022-03-15 09:59:27 -07:00
dustinfaceandGitHub 0036118177 tests: Add _PYTEST_RAISE to fix exception breakpoints with pytest (#10487)
It's currently not possible to have the debuger stop on an uncaucht 
exception when debugging tests. With this patch, adding 
`_PYTEST_RAISE=1` to the environment variables in the pytest 
configuration template fixes this.
2022-03-15 06:08:29 -07:00
William Blanke 622cdeb396 updated gui to c992d07c956501f92e84ead80127c6b1e882fc21 2022-03-14 13:10:16 -07:00
Kyle AltendorfandGitHub c63324abe9 remove some event_loop() fixtures (#10420)
* remove event_loop() fixtures

* flake8

* flake8

* remove sys.exit() from daemon shutdown

* bump full node test timeout.  a lot...  to see.

* fixup some tests

* back to module scope event loop fixture for test_full_node.py

* Update test_full_node.py

* Iterator...

* for the whole directory

* some fixtures back to module scope for reduced runtime

* back to 40 minute workflow timeouts

* these are being addressed separately
2022-03-14 06:08:35 -07:00
Kyle AltendorfandGitHub 4915477fcb bump pre-commit mypy to 0.940 (#10672) 2022-03-14 06:08:05 -07:00
Arvid NorbergandGitHub 773d692fc5 fix usage of the bt fixture in conftest fixtures (#10688) 2022-03-12 10:40:52 -08:00
dbeff36ae0 Add configuration locking (#10680)
* Add configuration locking

Extracted from https://github.com/Chia-Network/chia-blockchain/pull/10631

* note that fasteners will likely be replaced by filelock

* Fix test_multiple_writers on macOS

* create_all_ssl() doesn't need to be inside the config access lock

* add warnings about not using async within get_config_lock() get lock contexts

* no need to pre-touch the lock file

* .yaml.lock instead of just .lock

* test_multiple_writers() is sync

* Revert "add warnings about not using async within get_config_lock() get lock contexts"

This reverts commit 681af3835b.

* reduce lock context size in chia_init()

* use an exit stack in load_config()

* avoid config existence precheck

* only lock around the read in load_config()

* do not raise e, just raise

* tidy new imports

* fix queue empty check in test_config.py

* remove commented out code in test_config.py

* remove unused import

Co-authored-by: Jeff Cruikshank <jeff@chia.net>
2022-03-12 06:52:47 -08:00
Earle LoweandGitHub 19ee652d73 better TLS1.3 check (#10552)
* better TLS1.3 check

* catch ValueError instead of Exception

* Code simplification and cleanup

* a few nits in comments
2022-03-11 18:52:00 -08:00
JeffandGitHub 184920a55c Better management of KeyringWrapper's keys_root_path when using TempKeyring for tests (#10636)
* Better management of KeyringWrapper's keys_root_path when using TempKeyring for tests.

* Move keys_root_path restoration code into `cleanup()`
Added an assert to detect if an unexpected shared KeyringWrapper is injected during a test.

* Conditionally restore keys_root_path for testing
2022-03-11 18:48:45 -08:00
William Blanke 917fb5db4c updated gui to cdfa2b98217fa8755c0da4f7409e6f90032c4c4c 2022-03-11 18:04:07 -08:00
Adam KellyandGitHub 70639be906 Ak.convert fixtures (#10612)
* Use bt fixture

* rebase

* Use local_hostname

* flake8

* Remove set_shared_instance

* Remove unneeded comments

* Revert unrelated change

* Add back type signature - rebase issue

* Correct type for _configure_legacy_backend

* See what's going on during CI mypy run

* github workflows

* mypy typing

* Remove legacy Keyring create method

* Start daemon first

* Set chia-blockchain-gui to hash in main

* Fix two test files that were not importing self_hostname

* self_hostname fixture

* Convert all class fixtures to top level functions
2022-03-11 16:26:54 -08:00
Chris MarslenderandGitHub efdff0adba Check prefix on send_transaction before sending (#10566)
* Check prefix on send_transaction

* Fix failing RPC tests - xch -> txch since tests are a testnet and we enforce valid prefixes with this PR
2022-03-11 16:25:55 -08:00
Chris MarslenderandGitHub 230b785d3a Slightly different query for V2 DBs for getting compact/uncompact block counts, to ensure the available index is used / avoid a table scan (#10661) 2022-03-11 16:24:58 -08:00
JeffandGitHub 75ed1307e5 Fix exception when chia keys migrate is run without needing migration (#10655)
* Fix exception when `chia keys migrate` is run without needing migration

* Linter fixes
2022-03-11 16:23:24 -08:00
dustinfaceandGitHub 0bf370c642 plotting: Only lock while actually accessing PlotManager.plots (#10675) 2022-03-11 16:23:01 -08:00
austinsirkinandGitHub caaf7f40e1 Version control (#10479)
* Added version control enforcement to macOS m1

* Added enforced version control

* Added enforce version compliance

* Added enforced version compliance

* Added enforced versioning

* Updating this to include DRY internal action.

* Removed some unintended whitespace.

* Removed some unintended whitespace.

* CI re-run

* Trying to figure out why it's failing one test.

* Trying to figure out why it's failing one test.

* Trying to figure out why it's failing one test.
2022-03-11 15:57:35 -07:00
Don KackmanandGitHub ef4224d9e4 fix [Bug] #10569 (#10571) 2022-03-10 11:25:28 -08:00
Don KackmanandGitHub 7c717853a1 correct spelling of genrated (#10653) 2022-03-10 11:11:30 -08:00
Mariano SorgenteandGitHub fe964a48bd Fix invalid DB commit (#10594)
* Fix invalid DB commit

* More fixes

* Add raise

* Fix test
2022-03-10 11:11:04 -08:00
Johannes TysiakandGitHub e8ff5a32a7 fix initial-config typo - log_maxbytesrotation (#10598) 2022-03-10 11:10:28 -08:00
dustinfaceandGitHub 7a8cae2936 pools: Fix plotnft claim command's output (#10609)
If you currently claim rewards `claim_cmd` fails to print the txhash 
with the lookup hint in `submit_tx_with_confirmation`

```
Error performing operation on Plot NFT -f 172057028 wallet id: 12: 
'dict' object has no attribute 'name'
```

Because `submit_tx_with_confirmation` expects a `TransactionRecord` as 
result from its callable parameter `func` but `pw_absorb_rewards` 
returns a dict which includes the `TransactionRecord` as value for the 
key `transaction`. This PR makes sure all other methods used as `func` 
callable have the same return behaviour as `pw_absorb_rewards`. We could 
have adjusted it the other way around (only return `TransactionRecord` 
in `pw_absorb_rewards`) but then we would drop information in the RPC 
client.  


With this PR you get:

```
Do chia wallet get_transaction -f 172057028 -tx 
0x34f74a1ffd9da9a493b78463e635996fd03d4f805ade583acb9764df73355f9c to 
get status
```
2022-03-10 11:10:03 -08:00
JeffandGitHub 88f7c6bd83 chia keys show will default to displaying the first observer-derived wallet address. With the addition of the -d option, the non-observer derived wallet address can be displayed. (#10615) 2022-03-10 11:09:29 -08:00
Arvid NorbergandGitHub 5b0fb70d97 a problem with using random.randint() to pick a port is that all processes (running in parallel) are seeded the same, and so pick the same ports at the same time, causing conflicts. This uses proper entropy instead. (#10621) 2022-03-10 11:08:30 -08:00
Adam KellyandGitHub ff324095cc Remove block tools and keychain globals (#10358)
* Use bt fixture

* rebase

* Use local_hostname

* Fix test_json (inheritance from unittest.TestCase)

* Use correct BlockTools fixture for test_simulation

* Pass bt fixture into cost calculation tests

* flake8

* Add missing parameters to test functions

* Fix from rebase issues

* Remove set_shared_instance

* Update comment

* Remove unneeded comments

* Remove unused code

* Remove unused code, run `multiprocessing.set_start_method("spawn")` at correct time.

* Revert unrelated change

* Set daemon_port. Teardown services in correct order.
    BIG thanks to Mariano Sorgente for debugging help.

* Add back type signature - rebase issue

* Apply review fixes from Jeff

* Document why we need a later pytest-asyncio version

* Correct type for _configure_legacy_backend

* See what's going on during CI mypy run

* github workflows

* mypy typing

* Remove legacy Keyring create method

* Start daemon first

* Shutdown daemon coroutine properly

* Remove un-needed daemon_port argument

* Set chia-blockchain-gui to hash in main

* Remove connect_to_daemon_port

* Remove code that set "daemon_port" before calling `setup_daemon`

* Remove self_hostname fixture and extra self_hostname global

* Fix two test files that were not importing self_hostname

* self_hostname fixture

* Remove more unused test code

* Simplify  fixture
2022-03-10 11:06:49 -08:00
Arvid NorbergandGitHub 0e29dbc6d4 Bump CAT wallet test timeout to 40 minutes (#10605) 2022-03-09 03:41:18 -08:00
Kyle AltendorfandGitHub a0897d8d31 context manager for socket in find_available_listen_port(), catch OSError (#10567) 2022-03-09 03:40:52 -08:00
William AllenandGitHub 5b2f577278 Touching up changelog (#10584)
* removing known issue that was only applicable to a beta release

* Adding additional fixes to the changelog

* Adding Unreleased section to track upcoming changes
2022-03-08 18:28:22 -07:00
Kyle AltendorfandGitHub 6ff6fbe7de Fixup some hidden test errors (#10442) 2022-03-08 08:49:20 -08:00
Kyle AltendorfandGitHub 65deb79c41 make sync fixtures not use async def (#10504)
This is particularly relevant in cases where the scope is not function as
that forces use of a wider scoped event loop fixture as well.
2022-03-08 08:49:02 -08:00
Adam KellyandGitHub 5eca464919 Convert tests/core/util/test_streamable.py to use pytest. Remove unneeded class. (#10577) 2022-03-08 08:48:43 -08:00
Kyle AltendorfandGitHub 0992710492 Require pytest-asyncio>=0.17.0 for @fixture() (#10560) 2022-03-08 08:48:19 -08:00
William AllenandGitHub 0e7cc5a883 adding 1.3.0 release notes to changelog (#10578)
* adding 1.3.0 release notes to changelog

* Typos. thx @paninaro

* Adding requested adjustments to changelog
1.3.0
2022-03-07 18:12:31 -07:00
Mariano SorgenteandGitHub 4bd5c53f48 Add fee to changing pool, and more PlotNFT syncing fixes (#10545)
* Add fee to changing pool, and more aggressive disconnect of untrusted

* Don't publish fee TX

* Lint

* Small plotnft related fixes

* More plotnft fixes

* Apply quexington suggestion

* correct param for in_transaction

* Support get_transaction and get_transactions in plotnft

* Re-add publish_transaction and add comment

* Don't rerun additions
2022-03-04 17:10:04 -08:00
ChiaMineJPandGitHub 816251ec0d Fix install-gui.sh (#10460)
* Fixed an issue where running  with gui git branch specified failed

* Fixed an issue where install-gui.sh failed if npm>=7 and NodeJS < 16 were installed

* Fixed inconsistent npm path issue

* Fixed typo
2022-03-04 14:06:13 -08:00
Richard KissandGitHub 4c345e2fa5 Add some logging. (#10556) 2022-03-04 14:05:12 -08:00
Florin ChiricaandGitHub 058eb33abb Resubmit peak to timelord for failure. (#10551)
* Initial commit resubmit peak to timelord.

* Change how toandle exception.
2022-03-04 14:04:52 -08:00
dustinfaceandGitHub 0909fe7672 benchmarks: Implement streamable data comparison (#10433) 2022-03-04 09:51:39 -08:00