mirror of
https://github.com/docker/cli.git
synced 2026-09-01 02:24:23 -05:00
451dc6039462355a26aad02442428946bb7354d6
Some tests in `docker_api_containers_test.go` assume the docker daemon is running at the same machine as the cli and uses `ioutil.TempDir` to create temp dirs and use them in the test. On windows ioutil.TempDir and os.TempDir would create win-style paths and pass them to daemon. Instead, I hardcoded `/tmp/` and generate some random path manually and allow daemon to create the directory. Fixes tests: - TestContainerApiStartVolumeBinds - TestContainerApiStartDupVolumeBinds - TestVolumesFromHasPriority Downside: - Does not clean the temp dirs generated on the remote daemon machine unless delete container deletes them. Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com> Upstream-commit: df5334183fd681812f0d2cb03600d3eb0f3ef513 Component: engine
Languages
Go
92.3%
Shell
5.4%
Dockerfile
1.1%
Go-Checksums
0.7%
Makefile
0.3%
Other
0.2%