Kir Kolyshkin 7e8c2b86b6 cli/command/container: don't leak context ...

Switch from x/net/context to context made "go vet" see the previously
unseen errors:

> cli/command/container/start.go:57::error: the cancelFun function is
> not used on all paths (possible context leak) (vet)
> cli/command/container/start.go:63::error: this return statement may be
> reached without using the cancelFun var defined on line 57 (vet)

> cli/command/container/run.go:159::error: the cancelFun function is not
> used on all paths (possible context leak) (vet)
> cli/command/container/run.go:164::error: this return statement may be
> reached without using the cancelFun var defined on line 159 (vet)

Do call the cancel function.

Note we might end up calling it twice which is fine as long as I can see
from the Go 1.10 source code.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Upstream-commit: 395957155f
Component: cli

2018-05-11 16:50:04 -07:00

components/cli

cli/command/container: don't leak context

2018-05-11 16:50:04 -07:00

S

Description

The Docker CLI

clidocker

381 MiB

Languages

Go 92.3%

Shell 5.4%

Dockerfile 1.1%

Go-Checksums 0.7%

Makefile 0.3%

Other 0.2%