starred/coolify
1
0
Fork 0
mirror of https://github.com/coollabsio/coolify.git synced 2026-11-06 13:10:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #11730 from cbratschi/codex/fix-mongodb-healthcheck

Browse Source 
fix(database): use MongoDB writable-primary health check
This commit is contained in:
Andras Bacsai
2026-09-30 20:45:48 +02:00
parent 284adede6c cf4c6600df
commit 0604101781
2 changed files with 127 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Actions/Database/StartMongodb.php
+38 -5
View File
@@ -105,11 +105,7 @@ class StartMongodb
$this->database->destination->network,
],
'labels' => defaultDatabaseLabels($this->database)->toArray(),
'healthcheck' => $this->database->healthCheckConfiguration([
'CMD',
'echo',
'ok',
]),
'healthcheck' => $this->database->healthCheckConfiguration($this->generate_health_check_command()),
'mem_limit' => $this->database->limits_memory,
'memswap_limit' => $this->database->limits_memory_swap,
'mem_swappiness' => $this->database->limits_memory_swappiness,
@@ -332,6 +328,43 @@ class StartMongodb
return $environment_variables->all();
}
private function generate_health_check_command(): array
{
$usesLegacyShell = str($this->database->image)->startsWith('mongo:4');
$command = [
'CMD',
$usesLegacyShell ? 'mongo' : 'mongosh',
'--quiet',
'--host',
$this->database->uuid,
];
if ($this->database->enable_ssl) {
$command = [
...$command,
$usesLegacyShell ? '--ssl' : '--tls',
$usesLegacyShell ? '--sslCAFile' : '--tlsCAFile',
'/etc/mongo/certs/ca.pem',
];
if ($this->database->ssl_mode === 'verify-full') {
$command = [
...$command,
$usesLegacyShell ? '--sslPEMKeyFile' : '--tlsCertificateKeyFile',
'/etc/mongo/certs/server.pem',
];
}
}
return [
...$command,
'--eval',
$usesLegacyShell
? 'quit(db.isMaster().ismaster === true ? 0 : 1)'
: 'quit(db.hello().isWritablePrimary === true ? 0 : 1)',
];
}
private function add_custom_mongo_conf()
{
if (is_null($this->database->mongo_conf) || empty($this->database->mongo_conf)) {
tests/Unit/StartMongodbHealthCheckTest.php
+89
View File
@@ -0,0 +1,89 @@
<?php
use App\Actions\Database\StartMongodb;
use App\Models\StandaloneMongodb;
it('uses the generated MongoDB health check in the Compose configuration', function () {
$source = remoteOutputSource('app/Actions/Database/StartMongodb.php');
expect($source)
->toContain("'healthcheck' => \$this->database->healthCheckConfiguration(\$this->generate_health_check_command())")
->not->toContain("'healthcheck' => \$this->database->healthCheckConfiguration([\n 'CMD',\n 'echo',\n 'ok'");
});
function generatedMongodbHealthCheckCommand(array $attributes): array
{
$action = new StartMongodb;
$action->database = new StandaloneMongodb;
$action->database->setRawAttributes($attributes, true);
$method = new ReflectionMethod(StartMongodb::class, 'generate_health_check_command');
return $method->invoke($action);
}
it('generates a credential-free writable-primary MongoDB health check', function (string $image, bool $enableSsl, ?string $sslMode, array $expectedCommand) {
$command = generatedMongodbHealthCheckCommand([
'uuid' => 'mongodb-test-resource',
'image' => $image,
'enable_ssl' => $enableSsl,
'ssl_mode' => $sslMode,
'mongo_initdb_root_username' => 'root-user',
'mongo_initdb_root_password' => 'root-password',
]);
expect($command)->toBe($expectedCommand)
->and(implode(' ', $command))
->not->toContain('root-user')
->not->toContain('root-password')
->not->toContain('--tlsAllowInvalidHostnames')
->not->toContain('--tlsAllowInvalidCertificates');
})->with([
'without TLS' => ['mongo:8', false, null, [
'CMD', 'mongosh', '--quiet', '--host', 'mongodb-test-resource', '--eval',
'quit(db.hello().isWritablePrimary === true ? 0 : 1)',
]],
'TLS allow mode' => ['mongo:8', true, 'allow', [
'CMD', 'mongosh', '--quiet', '--host', 'mongodb-test-resource',
'--tls', '--tlsCAFile', '/etc/mongo/certs/ca.pem', '--eval',
'quit(db.hello().isWritablePrimary === true ? 0 : 1)',
]],
'TLS prefer mode' => ['mongo:8', true, 'prefer', [
'CMD', 'mongosh', '--quiet', '--host', 'mongodb-test-resource',
'--tls', '--tlsCAFile', '/etc/mongo/certs/ca.pem', '--eval',
'quit(db.hello().isWritablePrimary === true ? 0 : 1)',
]],
'TLS require mode' => ['mongo:8', true, 'require', [
'CMD', 'mongosh', '--quiet', '--host', 'mongodb-test-resource',
'--tls', '--tlsCAFile', '/etc/mongo/certs/ca.pem', '--eval',
'quit(db.hello().isWritablePrimary === true ? 0 : 1)',
]],
'TLS verify-full mode' => ['mongo:8', true, 'verify-full', [
'CMD', 'mongosh', '--quiet', '--host', 'mongodb-test-resource',
'--tls',
'--tlsCAFile',
'/etc/mongo/certs/ca.pem',
'--tlsCertificateKeyFile',
'/etc/mongo/certs/server.pem',
'--eval',
'quit(db.hello().isWritablePrimary === true ? 0 : 1)',
]],
'MongoDB 4 without TLS' => ['mongo:4.4', false, null, [
'CMD', 'mongo', '--quiet', '--host', 'mongodb-test-resource', '--eval',
'quit(db.isMaster().ismaster === true ? 0 : 1)',
]],
'MongoDB 4 TLS require mode' => ['mongo:4.4', true, 'require', [
'CMD', 'mongo', '--quiet', '--host', 'mongodb-test-resource',
'--ssl', '--sslCAFile', '/etc/mongo/certs/ca.pem', '--eval',
'quit(db.isMaster().ismaster === true ? 0 : 1)',
]],
'MongoDB 4 TLS verify-full mode' => ['mongo:4.4', true, 'verify-full', [
'CMD', 'mongo', '--quiet', '--host', 'mongodb-test-resource',
'--ssl',
'--sslCAFile',
'/etc/mongo/certs/ca.pem',
'--sslPEMKeyFile',
'/etc/mongo/certs/server.pem',
'--eval',
'quit(db.isMaster().ismaster === true ? 0 : 1)',
]],
]);