starred/coolify
1
0
Fork 0
mirror of https://github.com/coollabsio/coolify.git synced 2026-08-24 10:05:47 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(domains): allow adding domains without explicit ports (#11442)

Browse Source
This commit is contained in:
Andras Bacsai
2026-08-21 12:04:14 +02:00
committed by GitHub
parent 15072b9cf7
commit 83f1a2e503
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Support/DomainUrlParts.php
+2 -2
View File
@@ -4,11 +4,11 @@ namespace App\Support;
class DomainUrlParts
{
public static function compose(string $scheme, string $host, string $port = '', string $path = ''): string
public static function compose(string $scheme, string $host, ?string $port = '', string $path = ''): string
{
$scheme = strtolower(trim($scheme)) === 'http' ? 'http' : 'https';
$host = trim($host);
$port = trim($port);
$port = trim((string) $port);
$path = trim($path);
if ($path !== '' && ! str_starts_with($path, '/') && ! str_starts_with($path, '?') && ! str_starts_with($path, '#')) {
tests/Unit/DomainUrlPartsTest.php
+5
View File
@@ -28,3 +28,8 @@ it('defaults empty values for an invalid URL', function () {
it('preserves an explicitly configured default port', function () {
expect(DomainUrlParts::split('https://app.example.com:443')['port'])->toBe('443');
});
it('composes a domain when Livewire hydrates an empty numeric port as null', function () {
expect(DomainUrlParts::compose('https', 'app.example.com', null))
->toBe('https://app.example.com');
});