mirror of
https://github.com/coollabsio/coolify.git
synced 2026-09-26 17:30:46 -04:00
fix(parsers): remove unused $svc variable in dockercompose domain loop
Use array_keys() instead of key-value iteration since only the service name keys are needed for comparison. Addresses CodeRabbit review feedback.
This commit is contained in:
@@ -509,7 +509,7 @@ function applicationParser(Application $resource, int $pull_request_id = 0, ?int
|
||||
if ($resource->build_pack === 'dockercompose') {
|
||||
$normalizedFqdnFor = str($fqdnFor)->replace('-', '_')->replace('.', '_')->value();
|
||||
$serviceExists = false;
|
||||
foreach ($services as $serviceNameKey => $svc) {
|
||||
foreach (array_keys($services) as $serviceNameKey) {
|
||||
if (str($serviceNameKey)->replace('-', '_')->replace('.', '_')->value() === $normalizedFqdnFor) {
|
||||
$serviceExists = true;
|
||||
break;
|
||||
|
||||
Reference in New Issue
Block a user