starred/coolify
1
0
Fork 0
mirror of https://github.com/coollabsio/coolify.git synced 2026-08-24 02:24:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(server): move GitHub runners Save button next to title

Browse Source 
Place Save beside the page heading via form association and keep
Delete under the config form. Add a unit test asserting layout order.
This commit is contained in:
Andras Bacsai
2026-08-10 17:59:50 +02:00
parent ef276bdba6
commit b019249d39
2 changed files with 22 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
resources/views/livewire/server/github-runners.blade.php
+6 -6
View File
@@ -8,6 +8,7 @@
<div class="w-full">
<div class="flex items-center gap-2">
<h2>GitHub Actions Runners</h2>
<x-forms.button type="submit" form="github-runner-config-form" canGate="update" :canResource="$server">Save</x-forms.button>
@if ($this->config)
<x-forms.button wire:click="toggleEnabled" canGate="update" :canResource="$server">
{{ $this->config->is_enabled ? 'Disable' : 'Enable' }}
@@ -96,7 +97,7 @@
@endif
{{-- Configuration Form --}}
<form wire:submit="submit">
<form id="github-runner-config-form" wire:submit="submit">
<div class="flex flex-col gap-4">
<div>
<label for="selectedGithubAppId" class="block text-sm font-medium">GitHub App</label>
@@ -153,16 +154,15 @@
helper="Pin to a specific runner version (e.g. 2.321.0). Leave empty for latest." />
</div>
<div class="flex items-center gap-2 mt-2">
<x-forms.button type="submit" canGate="update" :canResource="$server">Save</x-forms.button>
@if ($this->config)
@if ($this->config)
<div class="flex items-center gap-2 mt-2">
<x-modal-confirmation title="Delete Runner Configuration?" buttonTitle="Delete Configuration"
submitAction="deleteConfig"
:actions="['This will remove the runner configuration from this server.', 'Active runners will not be affected until they complete.']"
:confirmWithText="false" :confirmWithPassword="false"
step2ButtonText="Delete Configuration" />
@endif
</div>
</div>
@endif
</div>
</form>
tests/Unit/GithubRunnersViewTest.php
+16
View File
@@ -0,0 +1,16 @@
<?php
it('places the github runners save button beside the page title', function () {
$view = file_get_contents(__DIR__.'/../../resources/views/livewire/server/github-runners.blade.php');
$titlePosition = strpos($view, '<h2>GitHub Actions Runners</h2>');
$savePosition = strpos($view, 'form="github-runner-config-form"');
$formPosition = strpos($view, '<form id="github-runner-config-form"');
expect($titlePosition)->not->toBeFalse()
->and($savePosition)->not->toBeFalse()
->and($formPosition)->not->toBeFalse()
->and($titlePosition)->toBeLessThan($savePosition)
->and($savePosition)->toBeLessThan($formPosition)
->and(substr_count($view, '>Save</x-forms.button>'))->toBe(1);
});