starred/coolify
1
0
Fork 0
mirror of https://github.com/coollabsio/coolify.git synced 2026-11-06 13:10:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(api): regenerate proxy labels when exposed ports change (#12334)

Browse Source
This commit is contained in:
Andras Bacsai
2026-10-26 19:28:18 +01:00
committed by GitHub
parent 0a9019f738
commit bafbc2e3d3
2 changed files with 79 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Controllers/Api/ApplicationsController.php
+1 -1
View File
@@ -3818,7 +3818,7 @@ class ApplicationsController extends Controller
// Must run after fqdn is filled: flags are kept only for domains the app still has.
$application->setNoindexDomains($request->input('noindex_domains') ?? []);
}
if ($application->settings->is_container_label_readonly_enabled && ($requestHasDomains || $requestHasNoindexDomains || $requestHasHttpBasicAuth) && $server->isProxyShouldRun()) {
if ($application->settings->is_container_label_readonly_enabled && ($requestHasDomains || $requestHasNoindexDomains || $requestHasHttpBasicAuth || $application->isDirty('ports_exposes')) && $server->isProxyShouldRun()) {
$application->custom_labels = str(implode('|coolify|', generateLabelsApplication($application)))->replace('|coolify|', "\n");
}
$application->withoutAuditLogging(fn () => $application->save());
tests/Feature/Api/ApplicationPortsExposesLabelsApiTest.php
+78
View File
@@ -0,0 +1,78 @@
<?php
use App\Models\Application;
use App\Models\Environment;
use App\Models\InstanceSettings;
use App\Models\Project;
use App\Models\Server;
use App\Models\StandaloneDocker;
use App\Models\Team;
use App\Models\User;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Illuminate\Support\Str;
uses(RefreshDatabase::class);
beforeEach(function () {
InstanceSettings::unguarded(fn () => InstanceSettings::firstOrCreate(['id' => 0]));
$this->team = Team::factory()->create();
$this->user = User::factory()->create();
$this->team->members()->attach($this->user->id, ['role' => 'owner']);
session(['currentTeam' => $this->team]);
$plainTextToken = Str::random(40);
$token = $this->user->tokens()->create([
'name' => 'ports-exposes-api-test-'.Str::random(6),
'token' => hash('sha256', $plainTextToken),
'abilities' => ['*'],
'team_id' => $this->team->id,
]);
$this->bearerToken = $token->getKey().'|'.$plainTextToken;
$this->server = Server::factory()->create(['team_id' => $this->team->id]);
$destination = StandaloneDocker::where('server_id', $this->server->id)->first();
$environment = Environment::factory()->create([
'project_id' => Project::factory()->create(['team_id' => $this->team->id])->id,
]);
$this->application = Application::factory()->create([
'environment_id' => $environment->id,
'destination_id' => $destination->id,
'destination_type' => $destination->getMorphClass(),
'fqdn' => 'https://app.example.com',
'ports_exposes' => '80',
]);
$this->application->settings->update(['is_container_label_readonly_enabled' => true]);
$this->application->update([
'custom_labels' => base64_encode(implode("\n", generateLabelsApplication($this->application->fresh()))),
]);
});
function patchPortsExposes(string $bearerToken, string $uuid, array $payload)
{
return test()->withHeaders(['Authorization' => 'Bearer '.$bearerToken])
->patchJson("/api/v1/applications/{$uuid}", $payload);
}
test('regenerates the load balancer port label when ports_exposes changes', function () {
expect((string) $this->application->fresh()->parseContainerLabels())
->toContain('loadbalancer.server.port=80');
patchPortsExposes($this->bearerToken, $this->application->uuid, ['ports_exposes' => '9000'])
->assertOk();
$labels = (string) $this->application->fresh()->parseContainerLabels();
expect($labels)->toContain('loadbalancer.server.port=9000')
->not->toContain('loadbalancer.server.port=80');
});
test('keeps custom labels when readonly labels are disabled', function () {
$this->application->settings->update(['is_container_label_readonly_enabled' => false]);
$this->application->update(['custom_labels' => base64_encode('my.custom=label')]);
patchPortsExposes($this->bearerToken, $this->application->uuid, ['ports_exposes' => '9000'])
->assertOk();
expect((string) $this->application->fresh()->parseContainerLabels())->toBe('my.custom=label');
});