starred/coolify
1
0
Fork 0
mirror of https://github.com/coollabsio/coolify.git synced 2026-09-24 15:30:03 -05:00
Code Issues Packages Projects Releases Wiki Activity

build(minio): use packaged mx client in development images

Browse Source
This commit is contained in:
Andras Bacsai
2026-09-15 23:00:45 +02:00
parent 113a2f229d
commit ede9d8417a
5 changed files with 19 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docker-compose-maxio.dev.yml
+2 -2
View File
@@ -162,7 +162,7 @@ services:
networks:
- coolify
# maxio-init:
# image: quay.io/minio/aistor/mc:RELEASE.2026-09-06T02-44-40Z
# image: ghcr.io/coollabsio/mx:0.1.0
# pull_policy: always
# container_name: coolify-maxio-init
# restart: no
@@ -182,7 +182,7 @@ services:
# networks:
# - coolify
minio-init:
image: quay.io/minio/aistor/mc:RELEASE.2026-09-06T02-44-40Z
image: ghcr.io/coollabsio/mx:0.1.0
pull_policy: always
container_name: coolify-minio-init
restart: no
docker-compose.dev-multi.yml
+1 -1
View File
@@ -195,7 +195,7 @@ services:
minio-init:
profiles: ["minio"]
image: quay.io/minio/aistor/mc:RELEASE.2026-09-06T02-44-40Z
image: ghcr.io/coollabsio/mx:0.1.0
pull_policy: always
restart: "no"
depends_on:
docker-compose.dev.yml
+1 -1
View File
@@ -150,7 +150,7 @@ services:
networks:
- coolify
minio-init:
image: quay.io/minio/aistor/mc:RELEASE.2026-09-06T02-44-40Z
image: ghcr.io/coollabsio/mx:0.1.0
pull_policy: always
container_name: coolify-minio-init
restart: no
docker/development/Dockerfile
+1 -1
View File
@@ -12,7 +12,7 @@ ARG NGINX_VERSION=1.31.2-r1
# =================================================================
# Get MinIO client
# =================================================================
FROM quay.io/minio/aistor/mc:RELEASE.2026-09-06T02-44-40Z AS minio-client
FROM ghcr.io/coollabsio/mx:0.1.0 AS minio-client
# =================================================================
# Final Stage: Production image
tests/Unit/MinioClientPackagingTest.php
+14 -8
View File
@@ -1,21 +1,27 @@
<?php
it('pins the AIStor MinIO client release in every Coolify image', function () {
$imageFiles = [
dirname(__DIR__, 2).'/docker/production/Dockerfile',
it('uses the mx MinIO-compatible client in development', function () {
$developmentFiles = [
dirname(__DIR__, 2).'/docker/development/Dockerfile',
dirname(__DIR__, 2).'/docker/coolify-helper/Dockerfile',
dirname(__DIR__, 2).'/docker-compose.dev.yml',
dirname(__DIR__, 2).'/docker-compose.dev-multi.yml',
dirname(__DIR__, 2).'/docker-compose-maxio.dev.yml',
];
foreach ($imageFiles as $imageFile) {
$contents = file_get_contents($imageFile);
foreach ($developmentFiles as $developmentFile) {
$contents = file_get_contents($developmentFile);
expect($contents)
->toContain('quay.io/minio/aistor/mc:RELEASE.2026-09-06T02-44-40Z')
->not->toContain('quay.io/minio/aistor/mc:latest')
->toContain('ghcr.io/coollabsio/mx:0.1.0')
->not->toContain('quay.io/minio/aistor/mc:')
->not->toContain('minio/mc:');
}
});
it('keeps the mc command path when packaging mx', function () {
$dockerfile = file_get_contents(dirname(__DIR__, 2).'/docker/development/Dockerfile');
expect($dockerfile)
->toContain('COPY --from=minio-client /usr/bin/mc /usr/bin/mc')
->not->toContain('COPY --from=minio-client /usr/bin/mx');
});