mirror of
https://github.com/coollabsio/coolify.git
synced 2026-11-14 16:52:45 -04:00
Andras BacsaiandClaude Opus 5.5
43933ee6cc
Installers before 4.5.1 and manual edits could leave ROOT_USERNAME (or the root email or password) with spaces and no quotes. The running container ignores .env because its config is cached, so the next upgrade recreated it and phpdotenv failed, which made every page return HTTP 500. The upgrade now quotes these values before it restarts Coolify. Closes #12375 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
68 lines
2.4 KiB
PHP
68 lines
2.4 KiB
PHP
<?php
|
|
|
|
use Dotenv\Dotenv;
|
|
|
|
/**
|
|
* Runs the upgrade script's quote_root_user_env_values helper against a temporary .env file
|
|
* and returns the file contents after the repair.
|
|
*/
|
|
function repairRootUserEnvWithUpgradeScript(string $scriptPath, string $initialEnv): string
|
|
{
|
|
$script = file_get_contents(dirname(__DIR__, 2).'/'.$scriptPath);
|
|
preg_match('/^quote_env_value\(\) \{.*?^\}$/ms', $script, $quoteEnvValue);
|
|
preg_match('/^quote_root_user_env_values\(\) \{.*?^\}$/ms', $script, $quoteRootUserEnvValues);
|
|
expect($quoteEnvValue)->not->toBeEmpty()
|
|
->and($quoteRootUserEnvValues)->not->toBeEmpty();
|
|
|
|
$envFile = tempnam(sys_get_temp_dir(), 'coolify-upgrade-env-');
|
|
file_put_contents($envFile, $initialEnv);
|
|
|
|
$process = proc_open(
|
|
['bash', '-c', implode("\n", ['set -e', 'log() { :; }', 'ENV_FILE='.escapeshellarg($envFile), $quoteEnvValue[0], $quoteRootUserEnvValues[0], 'quote_root_user_env_values'])],
|
|
[1 => ['pipe', 'w'], 2 => ['pipe', 'w']],
|
|
$pipes
|
|
);
|
|
$output = stream_get_contents($pipes[1]).stream_get_contents($pipes[2]);
|
|
fclose($pipes[1]);
|
|
fclose($pipes[2]);
|
|
expect(proc_close($process))->toBe(0, $output);
|
|
|
|
$contents = file_get_contents($envFile);
|
|
unlink($envFile);
|
|
|
|
return $contents;
|
|
}
|
|
|
|
$upgradeScripts = ['stable upgrade' => 'scripts/upgrade.sh', 'nightly upgrade' => 'other/nightly/upgrade.sh'];
|
|
|
|
it('quotes unquoted root user credentials with spaces so that .env parses again', function (string $scriptPath) {
|
|
$env = repairRootUserEnvWithUpgradeScript($scriptPath, implode("\n", [
|
|
'APP_NAME=Coolify',
|
|
'ROOT_USERNAME=Jane Doe',
|
|
'ROOT_USER_EMAIL=admin@example.com',
|
|
"ROOT_USER_PASSWORD=it's a P@ss|&\\ \$HOME",
|
|
'APP_ENV=production',
|
|
'',
|
|
]));
|
|
|
|
expect(Dotenv::parse($env))->toBe([
|
|
'APP_NAME' => 'Coolify',
|
|
'ROOT_USERNAME' => 'Jane Doe',
|
|
'ROOT_USER_EMAIL' => 'admin@example.com',
|
|
'ROOT_USER_PASSWORD' => "it's a P@ss|&\\ \$HOME",
|
|
'APP_ENV' => 'production',
|
|
]);
|
|
})->with($upgradeScripts);
|
|
|
|
it('keeps root user credentials that already parse unchanged', function (string $scriptPath) {
|
|
$initialEnv = implode("\n", [
|
|
'ROOT_USERNAME="Jane Doe"',
|
|
"ROOT_USER_EMAIL='admin@example.com'",
|
|
'ROOT_USER_PASSWORD=',
|
|
'APP_NAME=My Coolify',
|
|
'',
|
|
]);
|
|
|
|
expect(repairRootUserEnvWithUpgradeScript($scriptPath, $initialEnv))->toBe($initialEnv);
|
|
})->with($upgradeScripts);
|