starred/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2026-08-24 10:13:52 -05:00
Code Issues Packages Projects Releases Wiki Activity

Catch timeout errors in Steam config flow (#175052)

Browse Source
This commit is contained in:
Manu
2026-06-30 13:20:39 +00:00
committed by Franck Nijhof
parent 8cfc152725
commit 41f0a3a0e6
3 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
homeassistant/components/steam_online/config_flow.py
+8 -4
View File
@@ -65,12 +65,14 @@ class SteamFlowHandler(ConfigFlow, domain=DOMAIN):
name = str(res["personaname"])
else:
errors["base"] = "invalid_account"
except steam.api.HTTPTimeoutError:
errors["base"] = "timeout_connect"
except steam.api.HTTPError as ex:
errors["base"] = (
"invalid_auth" if "403" in str(ex) else "cannot_connect"
)
except Exception as ex: # noqa: BLE001
LOGGER.exception("Unknown exception: %s", ex)
except Exception: # noqa: BLE001
LOGGER.exception("Unknown exception")
errors["base"] = "unknown"
if not errors:
return self.async_create_entry(
@@ -107,12 +109,14 @@ class SteamFlowHandler(ConfigFlow, domain=DOMAIN):
validate_input, {**entry.data, **user_input}
):
errors["base"] = "invalid_account"
except steam.api.HTTPTimeoutError:
errors["base"] = "timeout_connect"
except steam.api.HTTPError as ex:
errors["base"] = (
"invalid_auth" if "403" in str(ex) else "cannot_connect"
)
except Exception as ex: # noqa: BLE001
LOGGER.exception("Unknown exception: %s", ex)
except Exception: # noqa: BLE001
LOGGER.exception("Unknown exception")
errors["base"] = "unknown"
if not errors:
homeassistant/components/steam_online/strings.json
+1
View File
@@ -8,6 +8,7 @@
"cannot_connect": "[%key:common::config_flow::error::cannot_connect%]",
"invalid_account": "Invalid Steam ID",
"invalid_auth": "[%key:common::config_flow::error::invalid_auth%]",
"timeout_connect": "[%key:common::config_flow::error::timeout_connect%]",
"unknown": "[%key:common::config_flow::error::unknown%]"
},
"step": {
tests/components/steam_online/test_config_flow.py
+2 -2
View File
@@ -54,7 +54,7 @@ async def test_flow_user(
@pytest.mark.parametrize(
("side_effect", "error_msg"),
[
(steam.api.HTTPTimeoutError, "cannot_connect"),
(steam.api.HTTPTimeoutError, "timeout_connect"),
(steam.api.HTTPError, "cannot_connect"),
(steam.api.HTTPError("403"), "invalid_auth"),
(ValueError, "unknown"),
@@ -146,7 +146,7 @@ async def test_flow_reauth(
@pytest.mark.parametrize(
("side_effect", "error_msg"),
[
(steam.api.HTTPTimeoutError, "cannot_connect"),
(steam.api.HTTPTimeoutError, "timeout_connect"),
(steam.api.HTTPError, "cannot_connect"),
(steam.api.HTTPError("403"), "invalid_auth"),
(ValueError, "unknown"),