starred/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2026-09-25 07:51:46 -05:00
Code Issues Packages Projects Releases Wiki Activity

Stop rounding Amber Electric prices to 2 decimal places (#181157)

Browse Source 
Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Wallace Fan
2026-09-03 12:54:34 +02:00
committed by GitHub
co-authored by Cursor
parent a79333ef5f
commit 45615ec7c4
4 changed files with 47 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
homeassistant/components/amberelectric/helpers.py
+2 -2
View File
@@ -24,5 +24,5 @@ def normalize_descriptor(descriptor: PriceDescriptor | None) -> str | None:
def format_cents_to_dollars(cents: float) -> float:
"""Return a formatted conversion from cents to dollars."""
return round(cents / 100, 2)
"""Convert cents per kWh to dollars per kWh."""
return cents / 100
tests/components/amberelectric/test_helpers.py
+20 -1
View File
@@ -1,8 +1,12 @@
"""Test formatters."""
from amberelectric.models.price_descriptor import PriceDescriptor
import pytest
from homeassistant.components.amberelectric.helpers import normalize_descriptor
from homeassistant.components.amberelectric.helpers import (
format_cents_to_dollars,
normalize_descriptor,
)
def test_normalize_descriptor() -> None:
@@ -15,3 +19,18 @@ def test_normalize_descriptor() -> None:
assert normalize_descriptor(PriceDescriptor.NEUTRAL) == "neutral"
assert normalize_descriptor(PriceDescriptor.HIGH) == "high"
assert normalize_descriptor(PriceDescriptor.SPIKE) == "spike"
@pytest.mark.parametrize(
("cents", "expected"),
[
pytest.param(8.8, 8.8 / 100, id="general"),
pytest.param(4.4, 4.4 / 100, id="controlled_load"),
pytest.param(1.1, 1.1 / 100, id="feed_in"),
pytest.param(0.09619, 0.0009619, id="near_zero"),
pytest.param(-0.09619, -0.0009619, id="near_zero_negative"),
],
)
def test_format_cents_to_dollars(cents: float, expected: float) -> None:
"""Test cents-to-dollars conversion preserves source precision."""
assert format_cents_to_dollars(cents) == expected
tests/components/amberelectric/test_sensor.py
+19 -19
View File
@@ -16,11 +16,11 @@ async def test_general_price_sensor(
assert len(hass.states.async_all()) == 6
price = hass.states.get("sensor.mock_title_general_price")
assert price
assert price.state == "0.09"
assert price.state == "0.088"
attributes = price.attributes
assert attributes["duration"] == 30
assert attributes["date"] == "2021-09-21"
assert attributes["per_kwh"] == 0.09
assert attributes["per_kwh"] == 8.8 / 100
assert attributes["nem_date"] == "2021-09-21T08:30:00+10:00"
assert attributes["spot_per_kwh"] == 0.01
assert attributes["start_time"] == "2021-09-21T08:00:00+10:00"
@@ -44,8 +44,8 @@ async def test_general_price_sensor_with_range(
price = hass.states.get("sensor.mock_title_general_price")
assert price
attributes = price.attributes
assert attributes.get("range_min") == 0.07
assert attributes.get("range_max") == 0.09
assert attributes.get("range_min") == 6.7 / 100
assert attributes.get("range_max") == 9.1 / 100
@pytest.mark.usefixtures("mock_amber_client_general_and_controlled_load")
@@ -58,11 +58,11 @@ async def test_general_and_controlled_load_price_sensor(
assert len(hass.states.async_all()) == 9
price = hass.states.get("sensor.mock_title_controlled_load_price")
assert price
assert price.state == "0.04"
assert price.state == "0.044"
attributes = price.attributes
assert attributes["duration"] == 30
assert attributes["date"] == "2021-09-21"
assert attributes["per_kwh"] == 0.04
assert attributes["per_kwh"] == 4.4 / 100
assert attributes["nem_date"] == "2021-09-21T08:30:00+10:00"
assert attributes["spot_per_kwh"] == 0.01
assert attributes["start_time"] == "2021-09-21T08:00:00+10:00"
@@ -83,11 +83,11 @@ async def test_general_and_feed_in_price_sensor(
assert len(hass.states.async_all()) == 9
price = hass.states.get("sensor.mock_title_feed_in_price")
assert price
assert price.state == "-0.01"
assert price.state == "-0.011"
attributes = price.attributes
assert attributes["duration"] == 30
assert attributes["date"] == "2021-09-21"
assert attributes["per_kwh"] == -0.01
assert attributes["per_kwh"] == -1.1 / 100
assert attributes["nem_date"] == "2021-09-21T08:30:00+10:00"
assert attributes["spot_per_kwh"] == 0.01
assert attributes["start_time"] == "2021-09-21T08:00:00+10:00"
@@ -108,7 +108,7 @@ async def test_general_forecast_sensor(
assert len(hass.states.async_all()) == 6
price = hass.states.get("sensor.mock_title_general_forecast")
assert price
assert price.state == "0.09"
assert price.state == "0.088"
attributes = price.attributes
assert attributes["channel_type"] == "general"
assert attributes["attribution"] == "Data provided by Amber Electric"
@@ -116,9 +116,9 @@ async def test_general_forecast_sensor(
first_forecast = attributes["forecasts"][0]
assert first_forecast["duration"] == 30
assert first_forecast["date"] == "2021-09-21"
assert first_forecast["per_kwh"] == 0.09
assert first_forecast["per_kwh"] == 8.8 / 100
assert first_forecast["nem_date"] == "2021-09-21T09:00:00+10:00"
assert first_forecast["spot_per_kwh"] == 0.01
assert first_forecast["spot_per_kwh"] == 1.1 / 100
assert first_forecast["start_time"] == "2021-09-21T08:30:00+10:00"
assert first_forecast["end_time"] == "2021-09-21T09:00:00+10:00"
assert first_forecast["renewables"] == 50
@@ -140,8 +140,8 @@ async def test_general_forecast_sensor_with_range(
assert price
attributes = price.attributes
first_forecast = attributes["forecasts"][0]
assert first_forecast.get("range_min") == 0.07
assert first_forecast.get("range_max") == 0.09
assert first_forecast.get("range_min") == 6.7 / 100
assert first_forecast.get("range_max") == 9.1 / 100
@pytest.mark.usefixtures("mock_amber_client_general_and_controlled_load")
@@ -154,7 +154,7 @@ async def test_controlled_load_forecast_sensor(
assert len(hass.states.async_all()) == 9
price = hass.states.get("sensor.mock_title_controlled_load_forecast")
assert price
assert price.state == "0.04"
assert price.state == "0.044"
attributes = price.attributes
assert attributes["channel_type"] == "controlledLoad"
assert attributes["attribution"] == "Data provided by Amber Electric"
@@ -162,9 +162,9 @@ async def test_controlled_load_forecast_sensor(
first_forecast = attributes["forecasts"][0]
assert first_forecast["duration"] == 30
assert first_forecast["date"] == "2021-09-21"
assert first_forecast["per_kwh"] == 0.04
assert first_forecast["per_kwh"] == 4.4 / 100
assert first_forecast["nem_date"] == "2021-09-21T09:00:00+10:00"
assert first_forecast["spot_per_kwh"] == 0.01
assert first_forecast["spot_per_kwh"] == 1.1 / 100
assert first_forecast["start_time"] == "2021-09-21T08:30:00+10:00"
assert first_forecast["end_time"] == "2021-09-21T09:00:00+10:00"
assert first_forecast["renewables"] == 50
@@ -181,7 +181,7 @@ async def test_feed_in_forecast_sensor(
assert len(hass.states.async_all()) == 9
price = hass.states.get("sensor.mock_title_feed_in_forecast")
assert price
assert price.state == "-0.01"
assert price.state == "-0.011"
attributes = price.attributes
assert attributes["channel_type"] == "feedIn"
assert attributes["attribution"] == "Data provided by Amber Electric"
@@ -189,9 +189,9 @@ async def test_feed_in_forecast_sensor(
first_forecast = attributes["forecasts"][0]
assert first_forecast["duration"] == 30
assert first_forecast["date"] == "2021-09-21"
assert first_forecast["per_kwh"] == -0.01
assert first_forecast["per_kwh"] == -1.1 / 100
assert first_forecast["nem_date"] == "2021-09-21T09:00:00+10:00"
assert first_forecast["spot_per_kwh"] == 0.01
assert first_forecast["spot_per_kwh"] == 1.1 / 100
assert first_forecast["start_time"] == "2021-09-21T08:30:00+10:00"
assert first_forecast["end_time"] == "2021-09-21T09:00:00+10:00"
assert first_forecast["renewables"] == 50
tests/components/amberelectric/test_services.py
+6 -6
View File
@@ -41,8 +41,8 @@ async def test_get_general_forecasts(
assert first["duration"] == 30
assert first["date"] == "2021-09-21"
assert first["nem_date"] == "2021-09-21T09:00:00+10:00"
assert first["per_kwh"] == 0.09
assert first["spot_per_kwh"] == 0.01
assert first["per_kwh"] == 8.8 / 100
assert first["spot_per_kwh"] == 1.1 / 100
assert first["start_time"] == "2021-09-21T08:30:00+10:00"
assert first["end_time"] == "2021-09-21T09:00:00+10:00"
assert first["renewables"] == 50
@@ -73,8 +73,8 @@ async def test_get_controlled_load_forecasts(
assert first["duration"] == 30
assert first["date"] == "2021-09-21"
assert first["nem_date"] == "2021-09-21T09:00:00+10:00"
assert first["per_kwh"] == 0.04
assert first["spot_per_kwh"] == 0.01
assert first["per_kwh"] == 4.4 / 100
assert first["spot_per_kwh"] == 1.1 / 100
assert first["start_time"] == "2021-09-21T08:30:00+10:00"
assert first["end_time"] == "2021-09-21T09:00:00+10:00"
assert first["renewables"] == 50
@@ -105,8 +105,8 @@ async def test_get_feed_in_forecasts(
assert first["duration"] == 30
assert first["date"] == "2021-09-21"
assert first["nem_date"] == "2021-09-21T09:00:00+10:00"
assert first["per_kwh"] == -0.01
assert first["spot_per_kwh"] == 0.01
assert first["per_kwh"] == -1.1 / 100
assert first["spot_per_kwh"] == 1.1 / 100
assert first["start_time"] == "2021-09-21T08:30:00+10:00"
assert first["end_time"] == "2021-09-21T09:00:00+10:00"
assert first["renewables"] == 50