Fix Teslemetry climate keeper preset for polling vehicles (#183681)

homeassistant/components/teslemetry/climate.py

@@ -50,6 +50,12 @@ PRESET_MODES = {
     "Dog": "dog",
     "Party": "camp",
 }
+POLLING_PRESET_MODES = {
+    "off": "off",
+    "on": "keep",
+    "dog": "dog",
+    "camp": "camp",
+}
 
 
 PARALLEL_UPDATES = 0
@@ -233,7 +239,10 @@ class TeslemetryVehiclePollingClimateEntity(
 
         self._attr_current_temperature = self.get("climate_state_inside_temp")
         self._attr_target_temperature = self.get(f"climate_state_{self.key}_setting")
-        self._attr_preset_mode = self.get("climate_state_climate_keeper_mode")
+        keeper_mode = self.get("climate_state_climate_keeper_mode")
+        self._attr_preset_mode = (
+            POLLING_PRESET_MODES.get(keeper_mode) if keeper_mode else None
+        )
         if self.get("climate_state_bioweapon_mode"):
             self._attr_fan_mode = "bioweapon"
         else:

tests/components/teslemetry/fixtures/vehicle_data.json

@@ -80,7 +80,7 @@
       "battery_heater_no_power": null,
       "cabin_overheat_protection": "On",
       "cabin_overheat_protection_actively_cooling": false,
-      "climate_keeper_mode": "keep",
+      "climate_keeper_mode": "on",
       "cop_activation_temperature": "High",
       "defrost_mode": 0,
       "driver_temp_setting": 22,

tests/components/teslemetry/snapshots/test_diagnostics.ambr

@@ -392,7 +392,7 @@
           'climate_state_battery_heater_no_power': None,
           'climate_state_cabin_overheat_protection': 'On',
           'climate_state_cabin_overheat_protection_actively_cooling': False,
-          'climate_state_climate_keeper_mode': 'keep',
+          'climate_state_climate_keeper_mode': 'on',
           'climate_state_cop_activation_temperature': 'High',
           'climate_state_defrost_mode': 0,
           'climate_state_driver_temp_setting': 22,

tests/components/teslemetry/test_climate.py

@@ -234,6 +234,41 @@ async def test_climate_state_unknown(
     assert hass.states.get("climate.test_climate").state == STATE_UNKNOWN
 
 
+@pytest.mark.parametrize(
+    ("keeper_mode", "preset_mode"),
+    [
+        pytest.param("on", "keep", id="on"),
+        pytest.param("dog", "dog", id="dog"),
+        pytest.param("camp", "camp", id="camp"),
+        pytest.param("keep", None, id="unmapped"),
+        pytest.param(None, None, id="unknown"),
+    ],
+)
+async def test_climate_polling_keeper_mode(
+    hass: HomeAssistant,
+    mock_metadata: AsyncMock,
+    mock_vehicle_data: AsyncMock,
+    keeper_mode: str | None,
+    preset_mode: str | None,
+) -> None:
+    """Test that a polling vehicle maps Tesla's climate keeper mode to a preset."""
+
+    metadata = deepcopy(METADATA)
+    metadata["vehicles"]["LRW3F7EK4NC700000"]["polling"] = True
+    mock_metadata.return_value = metadata
+
+    data = deepcopy(VEHICLE_DATA_ALT)
+    data["response"]["climate_state"]["climate_keeper_mode"] = keeper_mode
+    mock_vehicle_data.return_value = data
+
+    await setup_platform(hass, [Platform.CLIMATE])
+
+    assert (
+        hass.states.get("climate.test_climate").attributes[ATTR_PRESET_MODE]
+        == preset_mode
+    )
+
+
 async def test_invalid_error(hass: HomeAssistant, snapshot: SnapshotAssertion) -> None:
     """Tests service error is handled."""