starred/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2026-10-07 06:50:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix proxmox snapshot button sending name instead of snapname (#183042)

Browse Source
This commit is contained in:
Axel Glöckner
2026-09-25 14:05:49 +02:00
committed by GitHub
parent 8708fcdbf6
commit 8738c76386
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
homeassistant/components/proxmoxve/button.py
+2 -2
View File
@@ -177,7 +177,7 @@ VM_BUTTONS: tuple[ProxmoxVMButtonEntityDescription, ...] = (
coordinator.proxmox.nodes(node)
.qemu(vmid)
.snapshot.post(
name=f"homeassistant_snapshot_{dt_util.utcnow().strftime('%Y%m%d%H%M%S')}"
snapname=f"homeassistant_snapshot_{dt_util.utcnow().strftime('%Y%m%d%H%M%S')}"
)
),
permission=ProxmoxPermission.SNAPSHOT,
@@ -217,7 +217,7 @@ CONTAINER_BUTTONS: tuple[ProxmoxContainerButtonEntityDescription, ...] = (
coordinator.proxmox.nodes(node)
.lxc(vmid)
.snapshot.post(
name=f"homeassistant_snapshot_{dt_util.utcnow().strftime('%Y%m%d%H%M%S')}"
snapname=f"homeassistant_snapshot_{dt_util.utcnow().strftime('%Y%m%d%H%M%S')}"
)
),
permission=ProxmoxPermission.SNAPSHOT,
tests/components/proxmoxve/test_button.py
+3 -3
View File
@@ -176,9 +176,9 @@ async def test_snapshot_button(
# Proxmox validates the name as a `pve-configid` of at most 40 characters:
# two or more, starting with a letter, then only [A-Za-z0-9_-]
name = method_mock.call_args.kwargs["name"]
assert len(name) <= 40
assert re.fullmatch(r"[A-Za-z][A-Za-z0-9_-]+", name)
snapname = method_mock.call_args.kwargs["snapname"]
assert len(snapname) <= 40
assert re.fullmatch(r"[A-Za-z][A-Za-z0-9_-]+", snapname)
@pytest.mark.parametrize(