starred/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2026-09-25 07:51:46 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix Reolink sub_channel in ptz_speed capability check (#181675)

Browse Source
This commit is contained in:
starkillerOG
2026-09-09 11:16:13 +02:00
committed by GitHub
parent d94361eeb5
commit 8ee7b859b4
3 changed files with 9 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
homeassistant/components/reolink/button.py
+1 -1
View File
@@ -275,7 +275,7 @@ class ReolinkButtonEntity(ReolinkChannelCoordinatorEntity, ButtonEntity):
)
if (
self._host.api.supported(channel, "ptz_speed")
self._host.api.supported(channel, "ptz_speed", sub_channel)
and entity_description.ptz_cmd is not None
):
self._attr_supported_features = SUPPORT_PTZ_SPEED
tests/components/reolink/snapshots/test_button.ambr
+7 -14
View File
@@ -230,7 +230,7 @@
'platform': 'reolink',
'previous_unique_id': None,
'suggested_object_id': None,
'supported_features': <CameraEntityFeature: 2>,
'supported_features': 0,
'translation_key': 'ptz_auto',
'unique_id': 'ABC1234567D89EFG_DEF7654321D89GHT_ptz_auto',
'unit_of_measurement': None,
@@ -240,7 +240,6 @@
StateSnapshot({
'attributes': ReadOnlyDict({
<EntityStateAttribute.FRIENDLY_NAME: 'friendly_name'>: 'test_reolink_cam PTZ continuous rotation',
<EntityStateAttribute.SUPPORTED_FEATURES: 'supported_features'>: <CameraEntityFeature: 2>,
}),
'context': <ANY>,
'entity_id': 'button.test_reolink_cam_ptz_continuous_rotation',
@@ -383,7 +382,7 @@
'platform': 'reolink',
'previous_unique_id': None,
'suggested_object_id': None,
'supported_features': <CameraEntityFeature: 2>,
'supported_features': 0,
'translation_key': 'ptz_left_down',
'unique_id': 'ABC1234567D89EFG_DEF7654321D89GHT_ptz_left_down',
'unit_of_measurement': None,
@@ -393,7 +392,6 @@
StateSnapshot({
'attributes': ReadOnlyDict({
<EntityStateAttribute.FRIENDLY_NAME: 'friendly_name'>: 'test_reolink_cam PTZ left down',
<EntityStateAttribute.SUPPORTED_FEATURES: 'supported_features'>: <CameraEntityFeature: 2>,
}),
'context': <ANY>,
'entity_id': 'button.test_reolink_cam_ptz_left_down',
@@ -434,7 +432,7 @@
'platform': 'reolink',
'previous_unique_id': None,
'suggested_object_id': None,
'supported_features': <CameraEntityFeature: 2>,
'supported_features': 0,
'translation_key': 'ptz_left_up',
'unique_id': 'ABC1234567D89EFG_DEF7654321D89GHT_ptz_left_up',
'unit_of_measurement': None,
@@ -444,7 +442,6 @@
StateSnapshot({
'attributes': ReadOnlyDict({
<EntityStateAttribute.FRIENDLY_NAME: 'friendly_name'>: 'test_reolink_cam PTZ left up',
<EntityStateAttribute.SUPPORTED_FEATURES: 'supported_features'>: <CameraEntityFeature: 2>,
}),
'context': <ANY>,
'entity_id': 'button.test_reolink_cam_ptz_left_up',
@@ -536,7 +533,7 @@
'platform': 'reolink',
'previous_unique_id': None,
'suggested_object_id': None,
'supported_features': <CameraEntityFeature: 2>,
'supported_features': 0,
'translation_key': 'ptz_right_down',
'unique_id': 'ABC1234567D89EFG_DEF7654321D89GHT_ptz_right_down',
'unit_of_measurement': None,
@@ -546,7 +543,6 @@
StateSnapshot({
'attributes': ReadOnlyDict({
<EntityStateAttribute.FRIENDLY_NAME: 'friendly_name'>: 'test_reolink_cam PTZ right down',
<EntityStateAttribute.SUPPORTED_FEATURES: 'supported_features'>: <CameraEntityFeature: 2>,
}),
'context': <ANY>,
'entity_id': 'button.test_reolink_cam_ptz_right_down',
@@ -587,7 +583,7 @@
'platform': 'reolink',
'previous_unique_id': None,
'suggested_object_id': None,
'supported_features': <CameraEntityFeature: 2>,
'supported_features': 0,
'translation_key': 'ptz_right_up',
'unique_id': 'ABC1234567D89EFG_DEF7654321D89GHT_ptz_right_up',
'unit_of_measurement': None,
@@ -597,7 +593,6 @@
StateSnapshot({
'attributes': ReadOnlyDict({
<EntityStateAttribute.FRIENDLY_NAME: 'friendly_name'>: 'test_reolink_cam PTZ right up',
<EntityStateAttribute.SUPPORTED_FEATURES: 'supported_features'>: <CameraEntityFeature: 2>,
}),
'context': <ANY>,
'entity_id': 'button.test_reolink_cam_ptz_right_up',
@@ -739,7 +734,7 @@
'platform': 'reolink',
'previous_unique_id': None,
'suggested_object_id': None,
'supported_features': <CameraEntityFeature: 2>,
'supported_features': 0,
'translation_key': 'ptz_zoom_in',
'unique_id': 'ABC1234567D89EFG_DEF7654321D89GHT_ptz_zoom_in',
'unit_of_measurement': None,
@@ -749,7 +744,6 @@
StateSnapshot({
'attributes': ReadOnlyDict({
<EntityStateAttribute.FRIENDLY_NAME: 'friendly_name'>: 'test_reolink_cam PTZ zoom in',
<EntityStateAttribute.SUPPORTED_FEATURES: 'supported_features'>: <CameraEntityFeature: 2>,
}),
'context': <ANY>,
'entity_id': 'button.test_reolink_cam_ptz_zoom_in',
@@ -790,7 +784,7 @@
'platform': 'reolink',
'previous_unique_id': None,
'suggested_object_id': None,
'supported_features': <CameraEntityFeature: 2>,
'supported_features': 0,
'translation_key': 'ptz_zoom_out',
'unique_id': 'ABC1234567D89EFG_DEF7654321D89GHT_ptz_zoom_out',
'unit_of_measurement': None,
@@ -800,7 +794,6 @@
StateSnapshot({
'attributes': ReadOnlyDict({
<EntityStateAttribute.FRIENDLY_NAME: 'friendly_name'>: 'test_reolink_cam PTZ zoom out',
<EntityStateAttribute.SUPPORTED_FEATURES: 'supported_features'>: <CameraEntityFeature: 2>,
}),
'context': <ANY>,
'entity_id': 'button.test_reolink_cam_ptz_zoom_out',
tests/components/reolink/test_button.py
+1 -1
View File
@@ -32,7 +32,7 @@ async def test_all_entities(
"""Test all entities."""
def mock_supported(ch, capability, sub_channel=None):
if capability in {"ptz_stop", "pan", "tilt"}:
if capability in {"ptz_stop", "pan", "tilt", "ptz_speed"}:
return sub_channel == 1
if sub_channel is not None:
return False