starred/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2026-10-08 07:19:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

Keep colons in UniFi Protect custom doorbell messages (#184188)

Browse Source
This commit is contained in:
Raphael Hehl
2026-10-04 08:57:23 +02:00
committed by GitHub
parent 11c7c403b6
commit e20e1f4637
2 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
homeassistant/components/unifiprotect/select.py
+5 -3
View File
@@ -192,11 +192,13 @@ async def _set_paired_camera(obj: Light | Sensor, camera_id: str) -> None:
async def _set_doorbell_message(obj: Camera, message: str) -> None:
if message.startswith(DoorbellMessageType.CUSTOM_MESSAGE.value):
message = message.rsplit(":", maxsplit=1)[-1]
custom_prefix = f"{DoorbellMessageType.CUSTOM_MESSAGE.value}:"
if message.startswith(custom_prefix):
# reset_at=None keeps the message up until it is changed
await obj.set_lcd_message_public(
DoorbellMessageType.CUSTOM_MESSAGE, text=message, reset_at=None
DoorbellMessageType.CUSTOM_MESSAGE,
text=message.removeprefix(custom_prefix),
reset_at=None,
)
elif message == TYPE_EMPTY_VALUE:
await obj.set_lcd_message_public(None)
tests/components/unifiprotect/test_select.py
+9 -3
View File
@@ -639,11 +639,17 @@ async def test_select_set_option_camera_ir(
mock_method.assert_called_once_with(expected)
@pytest.mark.parametrize("message", ["Test", "Back at 5:30"])
async def test_select_set_option_camera_doorbell_custom(
hass: HomeAssistant, ufp: MockUFPFixture, doorbell: Camera
hass: HomeAssistant, ufp: MockUFPFixture, doorbell: Camera, message: str
) -> None:
"""Test Doorbell Text select (user defined message)."""
doorbell_settings = ufp.api.bootstrap.nvr.doorbell_settings
doorbell_settings.all_messages = [
*doorbell_settings.all_messages,
DoorbellMessage(type=DoorbellMessageType.CUSTOM_MESSAGE, text="Back at 5:30"),
]
await init_entry(hass, ufp, [doorbell])
assert_entity_counts(hass, Platform.SELECT, 5, 5)
@@ -657,14 +663,14 @@ async def test_select_set_option_camera_doorbell_custom(
await hass.services.async_call(
"select",
"select_option",
{ATTR_ENTITY_ID: entity_id, ATTR_OPTION: "Test"},
{ATTR_ENTITY_ID: entity_id, ATTR_OPTION: message},
blocking=True,
)
# reset_at=None keeps the message up; omitting it lets the NVR
# clear it after its own timeout
mock_method.assert_called_once_with(
DoorbellMessageType.CUSTOM_MESSAGE, text="Test", reset_at=None
DoorbellMessageType.CUSTOM_MESSAGE, text=message, reset_at=None
)