mirror of
https://github.com/home-assistant/core.git
synced 2026-09-25 07:51:46 -05:00
Drop the DC claim from the Fronius MPPT energy sensor (#181016)
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
b12015bc85
commit
f3a8fd917c
@@ -269,7 +269,7 @@ class FroniusModbusInverterUpdateCoordinator(FroniusModbusCoordinatorBase):
|
||||
values[f"mppt_{number}_current_dc"] = module.current
|
||||
values[f"mppt_{number}_voltage_dc"] = module.voltage
|
||||
values[f"mppt_{number}_power_dc"] = module.power
|
||||
values[f"mppt_{number}_energy_dc"] = module.energy
|
||||
values[f"mppt_{number}_energy"] = module.energy
|
||||
return self._as_device_data(values)
|
||||
|
||||
|
||||
|
||||
@@ -324,12 +324,12 @@ def _modbus_mppt_descriptions(
|
||||
translation_placeholders={"mppt_no": str(mppt_no)},
|
||||
),
|
||||
FroniusSensorEntityDescription(
|
||||
key=f"mppt_{mppt_no}_energy_dc",
|
||||
key=f"mppt_{mppt_no}_energy",
|
||||
native_unit_of_measurement=UnitOfEnergy.WATT_HOUR,
|
||||
device_class=SensorDeviceClass.ENERGY,
|
||||
state_class=SensorStateClass.TOTAL_INCREASING,
|
||||
invalid_when_falsy=True,
|
||||
translation_key="modbus_mppt_energy_dc",
|
||||
translation_key="modbus_mppt_energy",
|
||||
translation_placeholders={"mppt_no": str(mppt_no)},
|
||||
),
|
||||
]
|
||||
|
||||
@@ -264,8 +264,8 @@
|
||||
"modbus_mppt_current_dc": {
|
||||
"name": "MPPT {mppt_no} DC current"
|
||||
},
|
||||
"modbus_mppt_energy_dc": {
|
||||
"name": "MPPT {mppt_no} DC energy"
|
||||
"modbus_mppt_energy": {
|
||||
"name": "MPPT {mppt_no} energy"
|
||||
},
|
||||
"modbus_mppt_power_dc": {
|
||||
"name": "MPPT {mppt_no} DC power"
|
||||
|
||||
@@ -741,7 +741,7 @@
|
||||
'mppt_1_current_dc': dict({
|
||||
'value': 8.2,
|
||||
}),
|
||||
'mppt_1_energy_dc': dict({
|
||||
'mppt_1_energy': dict({
|
||||
'value': 1000000,
|
||||
}),
|
||||
'mppt_1_power_dc': dict({
|
||||
|
||||
@@ -74,7 +74,7 @@ async def test_gen24_storage_mppt(
|
||||
assert_state(hass, "sensor.gen24_storage_mppt_1_dc_current", 8.2)
|
||||
assert_state(hass, "sensor.gen24_storage_mppt_1_dc_voltage", 402.1)
|
||||
assert_state(hass, "sensor.gen24_storage_mppt_1_dc_power", 3300)
|
||||
assert_state(hass, "sensor.gen24_storage_mppt_1_dc_energy", 1000000)
|
||||
assert_state(hass, "sensor.gen24_storage_mppt_1_energy", 1000000)
|
||||
assert_state(hass, "sensor.gen24_storage_mppt_2_dc_power", 1650)
|
||||
assert_state(hass, "sensor.gen24_storage_mppt_3_dc_power", 0)
|
||||
assert_state(hass, "sensor.gen24_storage_mppt_4_dc_power", 480)
|
||||
@@ -301,7 +301,7 @@ async def test_not_implemented_values(
|
||||
|
||||
assert_state(hass, "sensor.inverter_name_mppt_1_dc_power", 3300)
|
||||
assert hass.states.get("sensor.inverter_name_mppt_2_dc_power") is None
|
||||
assert hass.states.get("sensor.inverter_name_mppt_2_dc_energy") is None
|
||||
assert hass.states.get("sensor.inverter_name_mppt_2_energy") is None
|
||||
# PV total unknown when a PV module doesn't report energy
|
||||
assert hass.states.get("sensor.inverter_name_pv_energy_total") is None
|
||||
|
||||
@@ -312,7 +312,7 @@ async def test_not_implemented_values(
|
||||
freezer.tick(FroniusModbusInverterUpdateCoordinator.default_interval)
|
||||
async_fire_time_changed(hass)
|
||||
await hass.async_block_till_done()
|
||||
assert_state(hass, "sensor.inverter_name_mppt_1_dc_energy", "unknown")
|
||||
assert_state(hass, "sensor.inverter_name_mppt_1_energy", "unknown")
|
||||
|
||||
|
||||
@pytest.mark.usefixtures("entity_registry_enabled_by_default")
|
||||
|
||||
Reference in New Issue
Block a user