starred/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2026-10-06 06:15:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Deduplicate dependency setup in _async_process_dependencies (#184048)

Browse Source 
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
epenet
2026-10-02 09:21:28 -05:00
committed by GitHub
co-authored by Claude Opus 5.5
parent c4035b579c
commit fbfef51ee9
1 changed files with 16 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
homeassistant/setup.py
+16 -23
View File
@@ -200,20 +200,22 @@ async def _async_process_dependencies(
setup_futures = hass.data.setdefault(_DATA_SETUP, {})
dependencies_tasks: dict[str, Awaitable[bool]] = {}
fut: Awaitable[bool]
def _dependency_awaitable(dep: str, kind: str) -> Awaitable[bool] | None:
"""Return an awaitable for the setup of dep, or None if already set up."""
if (shared_fut := setup_futures.get(dep)) is not None:
return wait_shared_future(shared_fut)
if dep in hass.config.components:
return None
return create_eager_task(
async_setup_component(hass, dep, config),
name=f"setup {dep} as {kind} of {integration.domain}",
loop=hass.loop,
)
for dep in integration.dependencies:
if (shared_fut := setup_futures.get(dep)) is not None:
fut = wait_shared_future(shared_fut)
elif dep in hass.config.components:
continue
else:
fut = create_eager_task(
async_setup_component(hass, dep, config),
name=f"setup {dep} as dependency of {integration.domain}",
loop=hass.loop,
)
dependencies_tasks[dep] = fut
if (fut := _dependency_awaitable(dep, "dependency")) is not None:
dependencies_tasks[dep] = fut
to_be_loaded = hass.data.get(_DATA_SETUP_DONE, {})
# We don't want to just wait for the futures from `to_be_loaded` here.
@@ -223,17 +225,8 @@ async def _async_process_dependencies(
for dep in integration.after_dependencies:
if dep not in to_be_loaded or dep in dependencies_tasks:
continue
if (shared_fut := setup_futures.get(dep)) is not None:
fut = wait_shared_future(shared_fut)
elif dep in hass.config.components:
continue
else:
fut = create_eager_task(
async_setup_component(hass, dep, config),
name=f"setup {dep} as after dependency of {integration.domain}",
loop=hass.loop,
)
dependencies_tasks[dep] = fut
if (fut := _dependency_awaitable(dep, "after dependency")) is not None:
dependencies_tasks[dep] = fut
if not dependencies_tasks:
return []