Merge pull request #19 from Chialab/issue/13-ci-refactor

Refactor CI tests
2026-08-24 10:13:24 -05:00 · 2017-10-18 18:26:03 +02:00
parent 9bbb5c6613 826bbbceca
commit 6053f46d94
3 changed files with 78 additions and 112 deletions
@@ -6,23 +6,27 @@ services:
  - docker

 env:
-  - DIR=.    VERSION=latest
-  - DIR=.    VERSION=5.4
-  - DIR=.    VERSION=5.5
-  - DIR=.    VERSION=5.6
-  - DIR=.    VERSION=7.0
-  - DIR=.    VERSION=7.1
-  - DIR=dev/ VERSION=latest
-  - DIR=dev/ VERSION=5.5
-  - DIR=dev/ VERSION=5.6
-  - DIR=dev/ VERSION=7.0
-  - DIR=dev/ VERSION=7.1
-
-before_install:
- make -C ${DIR} pull VERSION=${VERSION}
+  - VERSION=latest
+  - VERSION=5.4 NO_DEV=1
+  - VERSION=5.4-apache NO_DEV=1
+  - VERSION=5.4-fpm NO_DEV=1
+  - VERSION=5.5
+  - VERSION=5.5-apache
+  - VERSION=5.5-fpm
+  - VERSION=5.6
+  - VERSION=5.6-apache
+  - VERSION=5.6-fpm
+  - VERSION=7.0
+  - VERSION=7.0-apache
+  - VERSION=7.0-fpm
+  - VERSION=7.1
+  - VERSION=7.1-apache
+  - VERSION=7.1-fpm

 install:
- travis_wait 30 make -C ${DIR} build-nopull VERSION=${VERSION}
+- travis_wait 30 make build VERSION=${VERSION}
+- if [ "$NO_DEV" != "1" ]; then travis_wait 30 make -C dev build VERSION=${VERSION}; fi

 script:
- make -C ${DIR} test VERSION=${VERSION}
+- make test VERSION=${VERSION}
+- if [ "$NO_DEV" != "1" ]; then travis_wait 30 make -C dev test VERSION=${VERSION}; fi
@@ -5,13 +5,6 @@ PARENT_IMAGE := php
 IMAGE := chialab/php
 VERSION ?= latest

-# Tags.
-TAGS := $(VERSION)
-ifneq ($(VERSION),latest)
-	# Add `-apache` and `-fpm` suffix.
-	TAGS += $(VERSION)-apache $(VERSION)-fpm
-endif
-
 # Extensions.
 EXTENSIONS := \
 	bcmath \
@@ -40,48 +33,36 @@ ifeq ($(VERSION),$(filter 5.5 5.6 7.0 7.1 latest, $(VERSION)))
 	EXTENSIONS += OPcache
 endif

-pull:
-	@for tag in $(TAGS); do \
-		docker pull $(PARENT_IMAGE):$${tag}; \
-	done
-
-build-nopull:
-	@for tag in $(TAGS); do \
-		echo " =====> Building $(IMAGE):$${tag}..."; \
-		dir="$${tag/-//}"; \
-		if [[ "$${tag}" == 'latest' ]]; then \
-			dir='.'; \
-		fi; \
-		docker build --quiet -t $(IMAGE):$${tag} $${dir}; \
-	done
-
-build: pull build-nopull
+build:
+	@echo " =====> Building $(IMAGE):$(VERSION)..."
+	@dir="$(subst -,/,$(VERSION))"; \
+	if [[ "$(VERSION)" == 'latest' ]]; then \
+		dir='.'; \
+	fi; \
+	docker build --quiet -t $(IMAGE):$(VERSION) $${dir}

 test:
-	@echo 'Testing loaded extensions...'
-	@for tag in $(TAGS); do \
-		echo -e " - $${tag}... \c"; \
-		if [[ -z `docker images $(IMAGE) | grep "\s$${tag}\s"` ]]; then \
-			echo 'FAIL [Missing image!!!]'; \
+	@echo -e "=====> Testing loaded extensions... \c"
+	@if [[ -z `docker images $(IMAGE) | grep "\s$(VERSION)\s"` ]]; then \
+		echo 'FAIL [Missing image!!!]'; \
+		exit 1; \
+	fi
+	@modules=`docker run --rm $(IMAGE):$(VERSION) php -m`; \
+	for ext in $(EXTENSIONS); do \
+		if [[ "$${modules}" != *"$${ext}"* ]]; then \
+			echo "FAIL [$${ext}]"; \
 			exit 1; \
-		fi; \
-		modules=`docker run --rm $(IMAGE):$${tag} php -m`; \
-		for ext in $(EXTENSIONS); do \
-			if [[ "$${modules}" != *"$${ext}"* ]]; then \
-				echo "FAIL [$${ext}]"; \
-				exit 1; \
-			fi \
-		done; \
-		if [[ "$${tag}" == *'-apache' ]]; then \
-			apache=`docker run --rm $(IMAGE):$${tag} apache2ctl -M 2> /dev/null`; \
-			if [[ "$${apache}" != *'rewrite_module'* ]]; then \
-				echo 'FAIL [mod_rewrite]'; \
-				exit 1; \
-			fi \
-		fi; \
-		if [[ -z `docker run --rm $(IMAGE):$${tag} composer --version 2> /dev/null | grep '^Composer version [0-9][0-9]*\.[0-9][0-9]*'` ]]; then \
-			echo 'FAIL [Composer]'; \
-			exit 1; \
-		fi; \
-		echo 'OK'; \
+		fi \
 	done
+	@if [[ "$(VERSION)" == *'-apache' ]]; then \
+		apache=`docker run --rm $(IMAGE):$(VERSION) apache2ctl -M 2> /dev/null`; \
+		if [[ "$${apache}" != *'rewrite_module'* ]]; then \
+			echo 'FAIL [mod_rewrite]'; \
+			exit 1; \
+		fi \
+	fi
+	@if [[ -z `docker run --rm $(IMAGE):$(VERSION) composer --version 2> /dev/null | grep '^Composer version [0-9][0-9]*\.[0-9][0-9]*'` ]]; then \
+		echo 'FAIL [Composer]'; \
+		exit 1; \
+	fi
+	@echo 'OK'
@@ -5,13 +5,6 @@ PARENT_IMAGE := chialab/php
 IMAGE := chialab/php-dev
 VERSION ?= latest

-# Tags.
-TAGS := $(VERSION)
-ifneq ($(VERSION),latest)
-	# Add `-apache` and `-fpm` suffix.
-	TAGS += $(VERSION)-apache $(VERSION)-fpm
-endif
-
 # Extensions.
 EXTENSIONS := \
 	bcmath \
@@ -41,48 +34,36 @@ ifeq ($(VERSION),$(filter 5.5 5.6 7.0 7.1 latest, $(VERSION)))
 	EXTENSIONS += OPcache
 endif

-pull:
-	@for tag in $(TAGS); do \
-		docker pull $(PARENT_IMAGE):$${tag}; \
-	done
-
-build-nopull:
-	@for tag in $(TAGS); do \
-		echo " =====> Building $(IMAGE):$${tag}..."; \
-		dir="$${tag/-//}"; \
-		if [[ "$${tag}" == 'latest' ]]; then \
-			dir='.'; \
-		fi; \
-		docker build --quiet -t $(IMAGE):$${tag} $${dir}; \
-	done
-
-build: pull build-nopull
+build:
+	@echo " =====> Building $(IMAGE):$(VERSION)..."
+	@dir="$(subst -,/,$(VERSION))"; \
+	if [[ "$(VERSION)" == 'latest' ]]; then \
+		dir='.'; \
+	fi; \
+	docker build --quiet -t $(IMAGE):$(VERSION) $${dir}

 test:
-	@echo 'Testing loaded extensions...'
-	@for tag in $(TAGS); do \
-		echo -e " - $${tag}... \c"; \
-		if [[ -z `docker images $(IMAGE) | grep "\s$${tag}\s"` ]]; then \
-			echo 'FAIL [Missing image!!!]'; \
+	@echo -e "=====> Testing loaded extensions... \c"
+	@if [[ -z `docker images $(IMAGE) | grep "\s$(VERSION)\s"` ]]; then \
+		echo 'FAIL [Missing image!!!]'; \
+		exit 1; \
+	fi
+	@modules=`docker run --rm $(IMAGE):$(VERSION) php -m`; \
+	for ext in $(EXTENSIONS); do \
+		if [[ "$${modules}" != *"$${ext}"* ]]; then \
+			echo "FAIL [$${ext}]"; \
 			exit 1; \
-		fi; \
-		modules=`docker run --rm $(IMAGE):$${tag} php -m`; \
-		for ext in $(EXTENSIONS); do \
-			if [[ "$${modules}" != *"$${ext}"* ]]; then \
-				echo "FAIL [$${ext}]"; \
-				exit 1; \
-			fi \
-		done; \
-		if [[ "$${tag}" == *'-apache' ]]; then \
-			apache=`docker run --rm $(IMAGE):$${tag} apache2ctl -M 2> /dev/null`; \
-			if [[ "$${apache}" != *'rewrite_module'* ]]; then \
-				echo 'FAIL [mod_rewrite]'; \
-				exit 1; \
-			fi \
-		fi; \
-		if [[ -z `docker run --rm $(IMAGE):$${tag} composer --version 2> /dev/null | grep '^Composer version [0-9][0-9]*\.[0-9][0-9]*'` ]]; then \
-			echo 'FAIL [Composer]'; \
-			exit 1; \
-		fi; \
-		echo 'OK'; \
+		fi \
 	done
+	@if [[ "$(VERSION)" == *'-apache' ]]; then \
+		apache=`docker run --rm $(IMAGE):$(VERSION) apache2ctl -M 2> /dev/null`; \
+		if [[ "$${apache}" != *'rewrite_module'* ]]; then \
+			echo 'FAIL [mod_rewrite]'; \
+			exit 1; \
+		fi \
+	fi
+	@if [[ -z `docker run --rm $(IMAGE):$(VERSION) composer --version 2> /dev/null | grep '^Composer version [0-9][0-9]*\.[0-9][0-9]*'` ]]; then \
+		echo 'FAIL [Composer]'; \
+		exit 1; \
+	fi
+	@echo 'OK'