starred/docker
1
0
Fork 0
mirror of https://github.com/phpmyadmin/docker.git synced 2026-11-06 12:30:34 -04:00
Code Issues Packages Projects Releases Wiki Activity

Scope Docker Hub credentials to an environment

Browse Source 
Both jobs now reference the docker-hub environment, so the push token can be stored as an environment secret and stays out of every other job.

The plan job logs in again so its inspects use the account rate limit instead of the shared anonymous one. The username is read from vars.DOCKERHUB_USERNAME, as docker/login-action documents, while DOCKERHUB_TOKEN remains a secret.

Co-Authored-By: DeepSeek <noreply@deepseek.com>
Signed-off-by: William Desportes <williamdes@wdes.fr>
This commit is contained in:
William Desportes
2026-10-23 22:17:32 +02:00
co-authored by DeepSeek
parent 0342fe1801
commit 4f7341b000
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/mirror-official-images.yml
+13 -2
View File
@@ -30,6 +30,11 @@ jobs:
name: Plan
runs-on: ubuntu-latest
timeout-minutes: 20
# Authenticated so that the inspects use the account's rate limit instead
# of the shared anonymous one
environment:
name: docker-hub
url: https://hub.docker.com/r/phpmyadmin/phpmyadmin
outputs:
matrix: ${{ steps.plan.outputs.matrix }}
count: ${{ steps.plan.outputs.count }}
@@ -43,7 +48,7 @@ jobs:
- name: Log in to Docker Hub
run: ./.github/scripts/mirror-official-images.sh login
env:
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
DOCKERHUB_USERNAME: ${{ vars.DOCKERHUB_USERNAME }}
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
- name: Plan the tags to sync
id: plan
@@ -55,6 +60,12 @@ jobs:
if: ${{ needs.plan.outputs.count != '' && needs.plan.outputs.count != '0' }}
runs-on: ubuntu-latest
timeout-minutes: 90
# DOCKERHUB_TOKEN must be a secret of this environment, not of the
# repository, for only the jobs referencing it to see it. The username is
# not sensitive, so it lives in vars.DOCKERHUB_USERNAME
environment:
name: docker-hub
url: https://hub.docker.com/r/phpmyadmin/phpmyadmin
strategy:
fail-fast: false
max-parallel: 4
@@ -68,7 +79,7 @@ jobs:
- name: Log in to Docker Hub
run: ./.github/scripts/mirror-official-images.sh login
env:
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
DOCKERHUB_USERNAME: ${{ vars.DOCKERHUB_USERNAME }}
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
- name: Sync ${{ matrix.tag }}
run: ./.github/scripts/mirror-official-images.sh mirror "${TAG}"