mirror of
https://github.com/jesseduffield/lazygit.git
synced 2026-08-24 02:24:25 -05:00
Preallocate arrays where the new linter version would warn about it
This commit is contained in:
@@ -44,7 +44,8 @@ func (self *Hunk) lineCount() int {
|
||||
|
||||
// Returns all lines in the hunk, including the header line
|
||||
func (self *Hunk) allLines() []*PatchLine {
|
||||
lines := []*PatchLine{{Content: self.formatHeaderLine(), Kind: HUNK_HEADER}}
|
||||
lines := make([]*PatchLine, 1, 1+len(self.bodyLines))
|
||||
lines[0] = &PatchLine{Content: self.formatHeaderLine(), Kind: HUNK_HEADER}
|
||||
lines = append(lines, self.bodyLines...)
|
||||
return lines
|
||||
}
|
||||
|
||||
@@ -119,7 +119,7 @@ func (self *BaseContext) GetKey() types.ContextKey {
|
||||
}
|
||||
|
||||
func (self *BaseContext) GetKeybindings(opts types.KeybindingsOpts) []*types.Binding {
|
||||
bindings := []*types.Binding{}
|
||||
bindings := make([]*types.Binding, 0, len(self.keybindingsFns))
|
||||
for i := range self.keybindingsFns {
|
||||
// the first binding in the bindings array takes precedence but we want the
|
||||
// last keybindingsFn to take precedence to we add them in reverse
|
||||
@@ -216,7 +216,7 @@ func (self *BaseContext) AddOnQuitFn(fn func()) {
|
||||
}
|
||||
|
||||
func (self *BaseContext) GetMouseKeybindings(opts types.KeybindingsOpts) []*gocui.ViewMouseBinding {
|
||||
bindings := []*gocui.ViewMouseBinding{}
|
||||
bindings := make([]*gocui.ViewMouseBinding, 0, len(self.mouseKeybindingsFns))
|
||||
for i := range self.mouseKeybindingsFns {
|
||||
// the first binding in the bindings array takes precedence but we want the
|
||||
// last keybindingsFn to take precedence to we add them in reverse
|
||||
|
||||
@@ -295,8 +295,9 @@ func (gui *Gui) GetInitialKeybindings() ([]*types.Binding, []*gocui.ViewMouseBin
|
||||
},
|
||||
}
|
||||
|
||||
mouseKeybindings := []*gocui.ViewMouseBinding{}
|
||||
for _, c := range gui.State.Contexts.Flatten() {
|
||||
contexts := gui.State.Contexts.Flatten()
|
||||
mouseKeybindings := make([]*gocui.ViewMouseBinding, 0, len(contexts))
|
||||
for _, c := range contexts {
|
||||
viewName := c.GetViewName()
|
||||
for _, binding := range c.GetKeybindings(opts) {
|
||||
// TODO: move all mouse keybindings into the mouse keybindings approach below
|
||||
|
||||
@@ -256,14 +256,15 @@ func getLazygitCommand(
|
||||
return nil, err
|
||||
}
|
||||
|
||||
cmdArgs := []string{tempLazygitPath(), "-debug", "--use-config-dir=" + paths.Config()}
|
||||
|
||||
resolvedExtraArgs := lo.Map(test.ExtraCmdArgs(), func(arg string, _ int) string {
|
||||
return utils.ResolvePlaceholderString(arg, map[string]string{
|
||||
"actualPath": paths.Actual(),
|
||||
"actualRepoPath": paths.ActualRepo(),
|
||||
})
|
||||
})
|
||||
|
||||
cmdArgs := make([]string, 0, 3+len(resolvedExtraArgs))
|
||||
cmdArgs = append(cmdArgs, tempLazygitPath(), "-debug", "--use-config-dir="+paths.Config())
|
||||
cmdArgs = append(cmdArgs, resolvedExtraArgs...)
|
||||
|
||||
// Use a limited environment for test isolation, including pass through
|
||||
|
||||
Reference in New Issue
Block a user