starred/lazygit
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazygit.git synced 2026-11-06 13:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

Unify the code that loads all commits when scrolling near the end

Browse Source 
The commits and the sub-commits views had identical copies of it. A
later commit changes when it loads all commits, so make it one function
first.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Stefan Haller
2026-10-31 11:27:58 +01:00
co-authored by Claude Opus 5.5
parent 8055f5c139
commit b2e9d2a348
2 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/gui/controllers/local_commits_controller.go
+16 -5
View File
@@ -21,6 +21,21 @@ import (
// after selecting the 200th commit, we'll load in all the rest
const COMMIT_THRESHOLD = 200
type canLoadAllCommits interface {
GetSelectedLineIdx() int
GetLimitCommits() bool
SetLimitCommits(value bool)
}
// If we loaded only the first commits of a list, and the selection gets close to
// the end of them, load all of them.
func loadAllCommitsIfSelectionIsNearEnd(c *ControllerCommon, context canLoadAllCommits, scope types.RefreshableView) {
if context.GetSelectedLineIdx() > COMMIT_THRESHOLD && context.GetLimitCommits() {
context.SetLimitCommits(false)
c.Refresh(types.RefreshOptions{Scope: []types.RefreshableView{scope}})
}
}
// How long a commit move may take before the drop indicator switches to a
// "moving commits here" spinner; quick moves stay free of flicker.
const commitDragMovingIndicatorDelay = 200 * time.Millisecond
@@ -1807,11 +1822,7 @@ func (self *LocalCommitsController) handleOpenLogMenu() error {
func (self *LocalCommitsController) GetOnFocus() func(types.OnFocusOpts) {
return func(types.OnFocusOpts) {
context := self.context()
if context.GetSelectedLineIdx() > COMMIT_THRESHOLD && context.GetLimitCommits() {
context.SetLimitCommits(false)
self.c.Refresh(types.RefreshOptions{Scope: []types.RefreshableView{types.COMMITS}})
}
loadAllCommitsIfSelectionIsNearEnd(self.c, self.context(), types.COMMITS)
}
}
pkg/gui/controllers/sub_commits_controller.go
+1 -5
View File
@@ -64,10 +64,6 @@ func (self *SubCommitsController) GetOnRenderToMain() func() {
func (self *SubCommitsController) GetOnFocus() func(types.OnFocusOpts) {
return func(types.OnFocusOpts) {
context := self.context()
if context.GetSelectedLineIdx() > COMMIT_THRESHOLD && context.GetLimitCommits() {
context.SetLimitCommits(false)
self.c.Refresh(types.RefreshOptions{Scope: []types.RefreshableView{types.SUB_COMMITS}})
}
loadAllCommitsIfSelectionIsNearEnd(self.c, self.context(), types.SUB_COMMITS)
}
}