Compare commits

..
32 Commits
Author SHA1 Message Date
Jesse Duffield 2df78b257b don't pass single commands directly to RunCommand (or equivalent function)
when it contains percentages.

This is a really strange one. It's a linting warning in my editor
and it doesn't stop me from compiling, but it breaks `go test`.

A basic file to reproduce what I'm talking about:

package main

import "fmt"

func main() {
	notSprintf("test %s") // compiler complains here thinking %s needs a corresponding argument
}

func notSprintf(formatStr string, formatArgs ...interface{}) string {
	if formatArgs != nil {
		return formatStr
	}
	return fmt.Sprintf(formatStr, formatArgs...)
}
2019-11-21 21:59:25 +11:00
Jesse Duffield 85017d43a7 fix specs 2019-11-21 21:51:35 +11:00
Jesse Duffield 33fbe2d5c5 couple of things to clean up after rebasing onto master 2019-11-21 21:17:31 +11:00
Jesse Duffield 890fd2a511 give RunCommand the same input signature as fmt.Sprintf 2019-11-21 21:16:05 +11:00
Jesse Duffield 16a08da10d add tags panel 2019-11-21 21:16:05 +11:00
Jesse Duffield 0a04dacb06 allow editing remotes 2019-11-21 21:15:49 +11:00
Jesse Duffield 150aa76923 require double clicking menu items so you know what you're clicking 2019-11-21 21:15:49 +11:00
Jesse Duffield 03d838980a refactor confirmation prompt code 2019-11-21 21:15:49 +11:00
Jesse Duffield 05c179bfd1 better handling of click events in list views 2019-11-21 21:15:49 +11:00
Jesse Duffield b19866545e support setting upstream 2019-11-21 21:15:49 +11:00
Jesse Duffield a2077bec48 better fast forward 2019-11-21 21:15:49 +11:00
Jesse Duffield cb68452afd make upstream branch display more lenient on git errors 2019-11-21 21:15:49 +11:00
Jesse Duffield 57c0fc24de support rebasing onto remote branch 2019-11-21 21:15:49 +11:00
Jesse Duffield 2feb187a6c support deleting remote branches 2019-11-21 21:15:49 +11:00
Jesse Duffield cb9aa60830 ensure we switch tabs when switching context 2019-11-21 21:15:49 +11:00
Jesse Duffield 25177dfd2b support merging remote branches into checked out branch 2019-11-21 21:15:49 +11:00
Jesse Duffield f864eb1e65 support detached heads when showing the selected branch 2019-11-21 21:15:49 +11:00
Jesse Duffield 65f3073e7e support adding/removing remotes 2019-11-21 21:15:49 +11:00
Jesse Duffield ff75984796 split RemoteBranch out from Branch 2019-11-21 21:15:49 +11:00
Jesse Duffield 089c55a0b3 get branches with git for-each-ref 2019-11-21 21:15:27 +11:00
Jesse Duffield 620e49b8e3 only refresh branches panel on focus lost when in the local-branches context 2019-11-21 21:15:27 +11:00
Jesse Duffield 3b7e4cf2e6 support viewing a remote branch 2019-11-21 21:15:27 +11:00
Jesse Duffield 73ad5ec13c support navigating remotes view 2019-11-21 21:15:05 +11:00
Jesse Duffield 7296a6bff4 remove redundant logging 2019-11-21 21:15:05 +11:00
Jesse Duffield 5aed1c0499 allow changing tabs with [ and ] 2019-11-21 21:15:05 +11:00
Jesse Duffield 03ceb0b1ba get remote branches when getting remotes 2019-11-21 21:15:05 +11:00
Jesse Duffield 3ea79ef4e1 trying to use gogit with branches from remotes 2019-11-21 21:15:05 +11:00
Jesse Duffield fdb2880075 extract out some logic for list views 2019-11-21 21:15:05 +11:00
Jesse Duffield 404001be8a add contexts to views 2019-11-21 21:15:05 +11:00
Jesse Duffield 15c64d4bd8 bump gocui to get contexts on keybindings 2019-11-21 21:12:50 +11:00
Jesse Duffield 331616a5e8 add remotes context to branches view 2019-11-21 21:11:56 +11:00
Jesse Duffield 82b11bafef add remote model 2019-11-21 21:11:12 +11:00
2 changed files with 3 additions and 3 deletions
+1 -1
View File
@@ -424,7 +424,7 @@ func (gui *Gui) GetInitialKeybindings() []*Binding {
Key: 'P',
Modifier: gocui.ModNone,
Handler: gui.handlePushTag,
Description: gui.Tr.SLocalize("pushTag"),
Description: gui.Tr.SLocalize("pushTags"),
},
{
ViewName: "branches",
+2 -2
View File
@@ -904,8 +904,8 @@ func addEnglish(i18nObject *i18n.Bundle) error {
ID: "PushTagTitle",
Other: "remote to push tag '{{.tagName}}' to:",
}, &i18n.Message{
ID: "pushTag",
Other: "push tag",
ID: "pushTags",
Other: "push tags",
}, &i18n.Message{
ID: "createTag",
Other: "create tag",