starred/obs-studio
1
0
Fork 0
mirror of https://github.com/obsproject/obs-studio.git synced 2026-08-24 10:14:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

win-dshow: Fix possible crash if frame width or height is zero

Browse Source 
If a frame has a width or height of zero, this value will make it into
libobs/media-io/video-frame.c:video_frame_init and cause linesizes or
heights to be zero, which will result in a bmalloc(0) call and OBS will
crash.

Instead of letting the call stack get that far, check the frame width
and height here at the source, log an error, and return early if the
frame width or height are zero.
This commit is contained in:
Ryan Foster
2025-03-07 12:33:08 -05:00
parent 90570e7a70
commit 3437e2b082
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/win-dshow/win-dshow.cpp
+6
View File
@@ -936,6 +936,12 @@ bool DShowInput::UpdateVideoConfig(obs_data_t *settings)
return false;
}
if (!videoConfig.cx || !videoConfig.cy_abs) {
blog(LOG_ERROR, "%s: Frame width or height are zero (%" PRIu32 "x%" PRIu32 ")",
obs_source_get_name(source), videoConfig.cx, videoConfig.cy_abs);
return false;
}
DStr formatName = GetVideoFormatName(videoConfig.internalFormat);
double fps = 0.0;