fix: skip the pyodide plt.show patch when matplotlib is not loaded (#30381)

Any Python code that only mentioned "matplotlib" (a comment, a string, or an importlib.util.find_spec("matplotlib") check) failed with ModuleNotFoundError before a single line of it ran. The plt.show() patch was applied on a plain substring match, but matplotlib is only installed when the code actually imports it, so the patch's own import crashed the run. The user's try/except could not catch it, because their code never started. The same thing broke the code editor's Python formatter on any code that imports matplotlib, since that run only installs black.

The patch now also requires matplotlib to be present in the runtime's loaded packages, in both the worker and the sandboxed iframe host. Real matplotlib code still gets inline PNG output from plt.show(), and code that merely mentions matplotlib runs unchanged.

Gating on the callers' import regex instead was also tested and still fails the formatter case, because there the code containing the import sits inside a string while only black is installed.

Fixes #29894
This commit is contained in:
Classic298
2026-09-23 23:51:39 -04:00
committed by GitHub
parent 60ded561a9
commit 4e4b324246
2 changed files with 2 additions and 2 deletions
+1 -1
View File
@@ -134,7 +134,7 @@ const sandboxScript = String.raw`
let result = null;
if (files && files.length > 0) upload(files);
try {
if (code.includes('matplotlib')) await patchMatplotlib();
if (code.includes('matplotlib') && 'matplotlib' in pyodide.loadedPackages) await patchMatplotlib();
result = clean(await pyodide.runPythonAsync(code));
} catch (error) {
stderr = error && error.message ? error.message : String(error);
+1 -1
View File
@@ -191,7 +191,7 @@ async function executeCode(
try {
// check if matplotlib is imported in the code
if (code.includes('matplotlib')) {
if (code.includes('matplotlib') && 'matplotlib' in self.pyodide.loadedPackages) {
// Override plt.show() to return base64 image
await self.pyodide.runPythonAsync(`import base64
import os