starred/coolify
1
0
Fork 0
mirror of https://github.com/coollabsio/coolify.git synced 2026-09-27 09:45:58 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: address review — minio mc build stage + settings sidebar sticky

Browse Source 
- docker/development/Dockerfile: the minio-client build stage pulled
  minio/mc:${MINIO_VERSION} from Docker Hub (now 404), which fails a clean image
  build; repoint to quay.io/minio/mc with the same pinned tag
- shared-variables layout: drop inline xl:sticky/xl:top-26 (SettingsSidebarStickyTest
  forbids them); sticky positioning comes from the shared .application-settings-navigation
  CSS rule
This commit is contained in:
Aditya Tripathi
2026-09-14 10:05:47 +00:00
parent 7a96f0900d
commit 28de75af32
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docker/development/Dockerfile
+3 -1
View File
@@ -14,7 +14,9 @@ ARG NGINX_VERSION=1.31.2-r1
# =================================================================
# Get MinIO client
# =================================================================
FROM minio/mc:${MINIO_VERSION} AS minio-client
# MinIO removed the mc client from Docker Hub; pull the pinned build from
# MinIO's own registry (quay.io) instead.
FROM quay.io/minio/mc:${MINIO_VERSION} AS minio-client
# =================================================================
# Final Stage: Production image
resources/views/components/shared-variables/layout.blade.php
+1 -1
View File
@@ -15,7 +15,7 @@
</header>
<div class="grid min-w-0 gap-8 xl:mt-0 xl:grid-cols-[210px_minmax(0,1fr)] xl:gap-10">
<aside class="application-settings-navigation min-w-0 xl:sticky xl:top-26 xl:self-start">
<aside class="application-settings-navigation min-w-0 xl:self-start">
<nav aria-label="Shared variables"
class="grid grid-cols-2 gap-0.5 border-y border-neutral-200 py-3 sm:grid-cols-3 lg:grid-cols-5 xl:grid-cols-1 xl:border-y-0 xl:py-0 dark:border-white/[0.06]">
@foreach ($sharedVariablesMenuItems as $menuItem)