starred/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2026-10-06 14:29:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

Tell Copilot expired YAML import removal isn't breaking (#183680)

Browse Source
This commit is contained in:
Erwin Douna
2026-09-30 08:39:17 +02:00
committed by GitHub
parent 83300bc684
commit ae42f4150f
2 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/copilot-instructions.md
+1
View File
@@ -9,6 +9,7 @@
- When reviewing changes under `homeassistant/components/` or `tests/components/`, use the `ha-integration-knowledge` skill as the primary reference.
- Flag comments that over-explain straightforward code, narrate the obvious, or read like AI commentary (multi-sentence justifications for a single line).
- A Pull Request with a dependency version bump should only contain changes required for the version bump. If the PR includes other changes, request that they are removed from the PR.
- Do not ask to mark a Pull Request as a breaking change when it removes a YAML import whose deprecation period has ended; the deprecation already announced the removal.
- Check that the PR description is complete and filled in according to the PR template included below. Every section and checklist item from the template must be present, except the `## Breaking change` section which is optional. No content from the template should be missing, except for HTML comments and Markdown link reference definitions (lines of the form `[name]: url`), which do not render and cannot be verified from the description. Even unchecked checkboxes or empty sections must be present. This is a hard requirement.
- Skip the PR template check for pull requests generated by automated dependency bots. These are identifiable by their description: Renovate PRs contain "This PR was generated by [Mend Renovate]" and Dependabot PRs contain "Dependabot commands and options". All other review instructions still apply to these PRs.
script/gen_copilot_instructions.py
+1
View File
@@ -20,6 +20,7 @@ COPILOT_SPECIFIC_INSTRUCTIONS = """
- When reviewing changes under `homeassistant/components/` or `tests/components/`, use the `ha-integration-knowledge` skill as the primary reference.
- Flag comments that over-explain straightforward code, narrate the obvious, or read like AI commentary (multi-sentence justifications for a single line).
- A Pull Request with a dependency version bump should only contain changes required for the version bump. If the PR includes other changes, request that they are removed from the PR.
- Do not ask to mark a Pull Request as a breaking change when it removes a YAML import whose deprecation period has ended; the deprecation already announced the removal.
- Check that the PR description is complete and filled in according to the PR template included below. Every section and checklist item from the template must be present, except the `## Breaking change` section which is optional. No content from the template should be missing, except for HTML comments and Markdown link reference definitions (lines of the form `[name]: url`), which do not render and cannot be verified from the description. Even unchecked checkboxes or empty sections must be present. This is a hard requirement.
- Skip the PR template check for pull requests generated by automated dependency bots. These are identifiable by their description: Renovate PRs contain "This PR was generated by [Mend Renovate]" and Dependabot PRs contain "Dependabot commands and options". All other review instructions still apply to these PRs.